Page MenuHomePhabricator
Paste P147

MwEmbed jshint problems
ActivePublic

Authored by TheDJ on Dec 11 2014, 3:12 PM.
modules/EmbedPlayer/binPlayers/nativeBridge.js: line 61, col 14, Don't make functions within a loop.
modules/EmbedPlayer/resources/mw.EmbedPlayerImageOverlay.js: line 37, col 22, ['native_instaceOf'] is better written in dot notation.
modules/EmbedPlayer/resources/mw.EmbedPlayerJava.js: line 157, col 29, 'perc' is not defined.
modules/EmbedPlayer/resources/mw.EmbedPlayerJava.js: line 148, col 42, 'percentage' is defined but never used.
modules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js: line 34, col 18, 'base64_encode' is not defined.
modules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js: line 115, col 35, 'playerElementFlash' is defined but never used.
modules/EmbedPlayer/resources/mw.EmbedPlayerKplayer.js: line 352, col 33, 'id' is defined but never used.
modules/EmbedPlayer/resources/mw.EmbedPlayerVlc.js: line 150, col 21, 'rfsCount' is not defined.
modules/EmbedPlayer/resources/mw.EmbedTypes.js: line 34, col 21, 'chromecastPlayer' is defined but never used.
modules/EmbedPlayer/resources/mw.EmbedTypes.js: line 276, col 20, 'obj' is defined but never used.
modules/EmbedPlayer/resources/mw.FullScreenManager.js: line 460, col 66, Expected '!==' and instead saw '!='.
modules/EmbedPlayer/resources/mw.FullScreenManager.js: line 112, col 33, 'fullscreenHeight' is defined but never used.
modules/EmbedPlayer/resources/mw.MediaElement.js: line 354, col 179, 'displayWidth' used out of scope.
modules/EmbedPlayer/resources/mw.MediaElement.js: line 390, col 167, 'displayWidth' used out of scope.
modules/MwEmbedSupport/jquery/jquery.mwMessage.js: line 80, col 72, 'match' is not defined.
modules/MwEmbedSupport/jquery.loadingSpinner/jquery.loadingSpinner.js: line 81, col 35, Variables should not be deleted.
modules/MwEmbedSupport/mediawiki/mediawiki.UtilitiesUrl.js: line 37, col 50, 'src' is not defined.
modules/MwEmbedSupport/mw.MwEmbedSupport.js: line 195, col 13, Do not use 'new' for side effects.
modules/TimedText/resources/mw.TextSource.js: line 80, col 17, Do not use 'new' for side effects.

Event Timeline

TheDJ edited the content of this paste. (Show Details)Dec 11 2014, 3:12 PM
TheDJ changed the title of this paste from untitled to MwEmbed jshint problems.
TheDJ updated the paste's language from autodetect to autodetect.
TheDJ added a project: TimedMediaHandler.