HomePhabricator

Update patch set 4
618944e8aaeeUnpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update patch set 4

Patch Set 4:

I do object, see the test report above where strings are treated as

> URIs and some values missing. We need to get to the bottom of it
> before we merge. It's ok if it turns out to be playground bug in
> translating jsond to NT, but we need to be sure.

I agree. Let me look into this a bit. From your gist, the problematic

"pqv:P6": {
              "@id": "wdv:8378bc790f0763e24c5dab21194e34d6",
              "0": {
                  "@id": "wdv:d17b8276b35f21e03753ec9d887a5645"
              },

output appears in dump.json (*before* this patch) while the array appears correctly in dump2.json. So that seems to be an unrelated bug that was magically fixed by this patch. But let me dig into this a bit more, in particular to look at that type issue.

Patch-set: 4
Label: Verified=0

Details

Provenance
cscottAuthored on Oct 19 2017, 4:43 PM
Gerrit Code ReviewCommitted on Oct 19 2017, 4:43 PM
Parents
R1907:5b119808bc82: Update patch set 4
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed R1907:618944e8aaee: Update patch set 4 (authored by cscott).Oct 19 2017, 4:43 PM

Empty Commit

This commit is empty and does not affect any paths.