HomePhabricator

Rename `PropertyGrouping` object to `ItemGrouping` and move `YearGrouping`

Tags
None
Referenced Files
None
Subscribers
None

Description

Rename PropertyGrouping object to ItemGrouping and move YearGrouping

The 'Line' object concept tree introduced in 0d775cf2
mistakenly called this object PropertyGrouping,
but in reality it's not about the source of the grouping
but about its contents: in this case an Item page.

Indeed, the methods in that object are only about
formatting the grouping link in case of ItemPage,
and about formatting a higher-grouping, a concept
that only makes sense for Item groupings.

Also move YearGrouping straight under Grouping,
which tellingly does not require any change in tests.

The new tree is thus:

AbstractLine
└── Grouping

├── NoGroupGrouping
├── ItemGrouping
├── YearGrouping
├── UnknownValueGrouping
└── TotalsGrouping

(there could/might be a need in the future for
a level above Item and Year, but not for now).

Details

Provenance
JeanFredAuthored on May 28 2023, 10:40 AM
Parents
R2566:88906cb10993: Update isort to latest version 5.11.2 and update configuration
Branches
Unknown
Tags
Unknown
ChangeId
None