HomePhabricator

[IMPR] Simplify takesettings

Tags
None
Referenced Files
None
Subscribers
None

Description

[IMPR] Simplify takesettings

  • set self.settingsData to None on top of the method. It is no longer necessary to set them to None later except we got an empty list.
  • remove inner try/exeption and use page.text property which catch the NoPage exception and returns an empty string instead.
  • return after a wrong setting message has been printed.
  • remove comment which repeats the printed message.

Change-Id: Ia37362980d35cf26d4bccf35e1731e79f76eaeef

Details

Provenance
XqtAuthored on Apr 9 2024, 2:00 PM
Parents
R3347:cb4f18031169: [IMPR] Improvement for CheckImagesBot.takesettings()
Branches
Unknown
Tags
Unknown
ChangeId
Ia37362980d35cf26d4bccf35e1731e79f76eaeef

Event Timeline