Page MenuHomePhabricator

bad keyboard tabbing behavior in Special:Interwiki
Closed, ResolvedPublic

Description

Visit Special:Interwiki/add on a wiki where you have rights to edit the interwiki data.

As you press [Tab] the input focus cycles through,

  • "Prefix" field
  • URL, skipping Forward and Transclude checkboxes - BUG
  • Reason
  • Search box, skipping [Add] button - BUG
  • Navigation link and Search link
  • Forward checkbox
  • Transclude checkbox
  • [Add] button.

Expected result:
Page loads with "Prefix" focused, and tabbing takes you through all the form fields, including the checkboxes and [Add], in order, before going to skin fields.

I think the fix is to simply remove ' tabindex' => 1 from the text input fields in in Interwiki_body.php, then I get the expected tabbing behavior. Add add autocus to the first input field.

Event Timeline

Spage raised the priority of this task from to Needs Triage.
Spage updated the task description. (Show Details)
Spage subscribed.

Change 212835 had a related patch set uploaded (by Spage):
Fix tabbing

https://gerrit.wikimedia.org/r/212835

Hi!!
I am new to Wikimedia.
I want to start contributing..
Can you help me get started with this issue.

Screen Shot 2018-01-04 at 10.18.06 PM.png (591×1 px, 158 KB)

Above image shows the order that appears in my local dev workflow.

How did you wanted the order to be like?
I'll try and fix it.

P.S. Thanks for the link. Helped me a ton.

Change 212835 abandoned by Bartosz Dziewoński:
[mediawiki/extensions/Interwiki@master] Fix tabbing

Reason:
This patch no longer applies after the changes in 125f85027922dcb20efe49fb8b5dd97478f4916d :( The issue still exists, I'll submit another patch.

https://gerrit.wikimedia.org/r/212835

Change 626184 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Interwiki@master] Fix tabbing

https://gerrit.wikimedia.org/r/626184

Change 626184 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@master] Fix tabbing

https://gerrit.wikimedia.org/r/626184

matmarex claimed this task.