Page MenuHomePhabricator

Parameters of Infobox cricketer not properly set for Visual Editor
Closed, DeclinedPublic

Description

Check infobox https://en.wikipedia.org/wiki/Sir_John_Heathcoat-Amory,_3rd_Baronet for instance. There are still uses of the parameter name instead of the parameter display value.

Infobox cricketer is quite a popular infobox. I wonder in how many other infoboxes does this happen,

Event Timeline

Magioladitis raised the priority of this task from to Needs Triage.
Magioladitis updated the task description. (Show Details)
Magioladitis added a project: VisualEditor.
Magioladitis subscribed.

I don't actually think that this is a bug on the part of VE. VE just takes the template and parses it without error according to the instructions in the template's documentation. If we attack this problem from a VE angle, the only optiosn IMHO would be:

  1. Have VE refuse to display elements without a label. Certainly not the most user friendly behavior.
  2. Store a default mapping of items to labels that VE uses to look up labels for elements that don't have them. If you ask me, this would make the flow of instructions very disparate.

I do notice that many of the fields that are empty are common across several templates and just not implemented on the template in question (e.g. birth_date, death_date, etc.). Surely it would be good if it were possible to include fields that are defined once and then inherited or included in other templates - but that's probably over-ambitious.

@Magioladitis, I'm afraid I don't fully understand what the issue is. When you say "there are still uses of the parameter name instead of the parameter display value", what specifically are you referring to?

@Neil_P._Quinn_WMF when editing the infobox, instead of displaying "Birth date" and asking for a value for that field it displays "birth_date".

Currently this is solved by adding some piece of code (TemplateData) in \doc and apparently it has been partially(?) fixed after I reported it:
https://en.wikipedia.org/w/index.php?title=Template%3AInfobox_cricketer%2Fdoc&type=revision&diff=663792184&oldid=657134559

I still proposed that in cases where TemplateData is missing, there can be a fallback for some parameters (e.g. birth_date, death_date, etc.) and automatically use standard labels (e.g. "Birth date", "Death date" etc.).

About this report: One needs to check that TemplateData is complete for the infobox cricketer biography case and then close this.

@Magioladitis, makes sense, thank you for helping me catch up! I don't think it's worth building an additional system to do fallback display names; it could only catch a small number of cases which (like birth_date) weren't that confusing anyway.

I'll let you decide when to close this, but I don't think it makes sense to file a task for every template which doesn't have TemplateData. Also, you may be interested in the lists MZMcBride has been making of the most used templates on different wikis to help people check whether they have template data (T96323).

As VisualEditor was removed from this task, which project is this about? TemplateData? Or does this refer to on-wiki code that requires changes and hence is out of scope for tracking in a Phabricator task?

Krenair subscribed.

I think it's about hard-coding some common template parameter names into TemplateData to have specific default labels where the editors have not created TemplateData for the parameter.

Krenair claimed this task.

OK. So that means, it is community's responsibility to update TemplateData in popular infoboxes.