Page MenuHomePhabricator
Create Task
Maniphest T102467

checkimages.py: keep track of which file is already logged
Closed, ResolvedPublic
Actions

Description

checkimages tags file titles on a report page but the same files are listed over and over again.
Either insert the n_text template to the page or remember the already listed files

See https://de.wikipedia.org/wiki/Benutzer:Xqbot/Report for a sample

Details

SubjectRepoBranchLines +/-
[bugfix] Ignore asterisk while comparing reported linespywikibot/coremaster+28 -51
[bugfix] add the image name before comparing the contentpywikibot/coremaster+4 -3
[bugfix]: Do not flood log page.pywikibot/coremaster+17 -34
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Jun 15 2015, 10:39 AM
Xqt raised the priority of this task from to Medium.
Xqt updated the task description. (Show Details)
Xqt added projects: Pywikibot, Pywikibot-Scripts.
Xqt subscribed.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 15 2015, 10:39 AM
Xqt added a comment.Jul 14 2015, 9:29 AM

Seems some regexes passed to report_image() does not work as expected

Xqt claimed this task.Jul 14 2015, 5:26 PM
gerritbot subscribed.Jul 19 2015, 7:23 PM

Change 224597 had a related patch set uploaded (by Xqt):
[bugfix]: missing re.MULTILINE flag to match "$" line ending

https://gerrit.wikimedia.org/r/224597

gerritbot added a project: Patch-For-Review.Jul 19 2015, 7:23 PM
Xqt raised the priority of this task from Medium to High.Sep 16 2015, 1:05 PM

Enough time for this simple patch.

gerritbot added a comment.Sep 16 2015, 3:26 PM

Change 224597 had a related patch set uploaded (by Xqt):
[bugfix]: Do not flood log page.

https://gerrit.wikimedia.org/r/224597

gerritbot added a comment.Sep 16 2015, 3:31 PM

Change 224597 merged by jenkins-bot:
[bugfix]: Do not flood log page.

https://gerrit.wikimedia.org/r/224597

Xqt mentioned this in rPWBC22401a020957: [bugfix]: Do not flood log page..Sep 16 2015, 3:31 PM
Xqt closed this task as Resolved.Sep 16 2015, 3:44 PM
gerritbot added a comment.Oct 25 2015, 1:33 PM

Change 248686 had a related patch set uploaded (by Xqt):
[bugfix] add the image name before comparing the content

https://gerrit.wikimedia.org/r/248686

gerritbot added a comment.Oct 25 2015, 7:12 PM

Change 248686 merged by jenkins-bot:
[bugfix] add the image name before comparing the content

https://gerrit.wikimedia.org/r/248686

gerritbot added a comment.Nov 7 2015, 11:20 AM

Change 251695 had a related patch set uploaded (by Xqt):
[bugfix] Ignore asterisk while comparing reported lines

https://gerrit.wikimedia.org/r/251695

gerritbot added a comment.Nov 9 2015, 5:07 AM

Change 251695 merged by jenkins-bot:
[bugfix] Ignore asterisk while comparing reported lines

https://gerrit.wikimedia.org/r/251695

Xqt merged a task: T99238: checkimages.py writes the same log entry again and again.Feb 25 2016, 4:59 AM
Xqt added a subscriber: jayvdb.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL