Page MenuHomePhabricator
Create Task
Maniphest T103851

Mediawiki theme: focus inset overlaps scrollbars
Closed, ResolvedPublic
Actions

Description

pasted_file (123×392 px, 3 KB)

I think the only way to fix this is by applying the styles to the wrapper, but then you'd need to pass the focus state of the textarea to the wrapper, instead of using :focus (which wouldn't work in plain PHP mode, so it would need to degrade gracefully).

Solution
Fixed with exception of browsers (IE/Edge) which don't support this standard property (yet).

BeforeAfter
T103851 multiline textinput _before OOjs UI Demos 2017-01-30.png (168×1 px, 15 KB)
T103851 multiline textinput _after OOjs UI Demos 2017-01-30.png (172×1 px, 15 KB)

Details

SubjectRepoBranchLines +/-
Mediawiki theme: Fix focus inset to overlap scrollbarsoojs/uimaster+11 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Jun 25 2015, 1:44 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2015, 1:44 PM
Volker_E subscribed.Sep 17 2015, 5:11 AM
Jdforrester-WMF triaged this task as Low priority.Mar 22 2016, 6:39 PM
Jdforrester-WMF set Security to None.
gerritbot subscribed.Jan 31 2017, 1:24 AM

Change 335178 had a related patch set uploaded (by VolkerE):
Mediawiki theme: Fix focus inset to overlap scrollbars

https://gerrit.wikimedia.org/r/335178

gerritbot added a project: Patch-For-Review.Jan 31 2017, 1:24 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Jan 31 2017, 1:24 AM
Volker_E added a comment.Jan 31 2017, 1:30 AM
BeforeAfter
T103851 multiline textinput _before OOjs UI Demos 2017-01-30.png (168×1 px, 15 KB)
T103851 multiline textinput _after OOjs UI Demos 2017-01-30.png (172×1 px, 15 KB)
Volker_E closed this task as Resolved.Feb 4 2017, 12:22 AM
Volker_E claimed this task.

Fixed with exception of browser who don't support this standard property (yet).

gerritbot added a comment.Feb 4 2017, 12:32 AM

Change 335178 merged by jenkins-bot:
Mediawiki theme: Fix focus inset to overlap scrollbars

https://gerrit.wikimedia.org/r/335178

Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.19.1 on the OOUI board.Feb 4 2017, 12:40 AM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.19.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.Feb 6 2017, 8:34 PM
Volker_E updated the task description. (Show Details)
Volker_E removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits