NPE in JsonPageLoadStrategy.updateCurrentBackStackItem
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bearND
	Jun 27 2015, 9:42 PM

Description

Stack trace

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.util.ArrayList.isEmpty()' on a null object reference
at org.wikipedia.page.JsonPageLoadStrategy.updateCurrentBackStackItem(JsonPageLoadStrategy.java:502)
at org.wikipedia.page.JsonPageLoadStrategy.onSaveInstanceState(JsonPageLoadStrategy.java:215)
at org.wikipedia.page.PageViewFragmentInternal.onSaveInstanceState(PageViewFragmentInternal.java:424)
at android.support.v4.app.Fragment.performSaveInstanceState(Fragment.java:1936)
at android.support.v4.app.FragmentManagerImpl.saveFragmentBasicState(FragmentManager.java:1654)
at android.support.v4.app.FragmentManagerImpl.saveAllState(FragmentManager.java:1722)
at android.support.v4.app.FragmentActivity.onSaveInstanceState(FragmentActivity.java:527)
at org.wikipedia.page.PageActivity.onSaveInstanceState(PageActivity.java:789)
at android.app.Activity.performSaveInstanceState(Activity.java:1298)
at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1288)
at android.app.ActivityThread.callCallActivityOnSaveInstanceState(ActivityThread.java:3958)

OTRS

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8463232
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8464533
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8465172
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom&TicketID=8465936

Environment observed

App version: 2.0.104-beta-2015-06-25
Android OS versions: 5.1.1, 4.4.2

Details

	Subject	Repo	Branch	Lines +/-
	Avoid NPE in JsonPageLoadStrategy.onSaveInstanceState	apps/android/wikipedia	master	+8 -3

Customize query in gerrit

Related Objects

Mentioned In: T103788: Android Production Release 2.0.105
rAPAW26deba89a31c: Avoid NPE in JsonPageLoadStrategy.onSaveInstanceState

Event Timeline

• bearND created this task.Jun 27 2015, 9:42 PM

• bearND raised the priority of this task from to High.

• bearND updated the task description. (Show Details)

• bearND added a project: Wikipedia-Android-App-Backlog.

• bearND moved this task to Needs Triage on the Wikipedia-Android-App-Backlog board.

• bearND subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2015, 9:42 PM

• bearND added a project: Mobile-App-Sprint-60-Android-Lightning-Round.Jun 27 2015, 9:43 PM

• bearND set Security to None.

• bearND moved this task from Needs Triage to Current Sprint on the Wikipedia-Android-App-Backlog board.Jun 28 2015, 3:56 AM

• bearND updated the task description. (Show Details)Jun 28 2015, 9:45 PM

Change 221970 had a related patch set uploaded (by BearND):
Avoid NPE in JsonPageLoadStrategy.onSaveInstanceState

https://gerrit.wikimedia.org/r/221970

gerritbot added a project: Patch-For-Review.Jun 30 2015, 7:42 PM

• bearND claimed this task.Jun 30 2015, 7:42 PM

• bearND moved this task from To Do to Code Review on the Mobile-App-Sprint-60-Android-Lightning-Round board.

Change 221970 merged by jenkins-bot:
Avoid NPE in JsonPageLoadStrategy.onSaveInstanceState

https://gerrit.wikimedia.org/r/221970

• bearND mentioned this in rAPAW26deba89a31c: Avoid NPE in JsonPageLoadStrategy.onSaveInstanceState.Jun 30 2015, 9:01 PM

Dbrant moved this task from Code Review to QA Signoff on the Mobile-App-Sprint-60-Android-Lightning-Round board.Jun 30 2015, 9:13 PM

• bearND mentioned this in T103788: Android Production Release 2.0.105.Jun 30 2015, 11:27 PM

Dbrant edited projects, added Mobile-App-Sprint-61-Android-Beach-Boys; removed Mobile-App-Sprint-60-Android-Lightning-Round.Jul 7 2015, 7:25 PM

Dbrant moved this task from To Do to QA Signoff on the Mobile-App-Sprint-61-Android-Beach-Boys board.

Dbrant moved this task from QA Signoff to Done on the Mobile-App-Sprint-61-Android-Beach-Boys board.Jul 16 2015, 5:33 PM

• bearND closed this task as Resolved.Jul 20 2015, 4:58 PM

Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Jul 21 2015, 12:07 PM

NPE in JsonPageLoadStrategy.updateCurrentBackStackItemClosed, ResolvedPublicActions