angus wrote:

I still should get the diff between the current row and the
last revision (even if it isn't listed in the page).

I meant "between the current and the last revision".

angus wrote:

Ugh... it was correct already. Apparently I can't understand my own broken
English. Forget the last comment (and this). Sorry for the noise.

Created attachment 5613
Quickie patch

Hmm... this is a pretty easy change, but I am a little leery -- if you copy-and-paste the link to share w/ other editors it'll show different things as time goes on, so it's not a stable link.

Attached:

herd wrote:

As it existed in older versions with diff=0, stability was definitely a problem.

Some ideas:

• Add the (cur) link to the generated diff itself, thus removing the need to have it on the history page. Possibly near "previous" "next" links (as show for non-top diffs). Maybe even a media player type set of 4 buttons "first, previous, next, latest".
• Keep the data, that is keep the oldid= and diff= URL parameters as is, but override it with another parameter, such as cur=true. This would allow a link to work as expected. But for pasted/old examples, it could be reverse engineered by removing this parameter (as per similar situation with &curid=1 and &redlink=1, that override default behavior) to see what was seen originally.

mike.lifeguard+bugs wrote:

(In reply to comment #3)

Created an attachment (id=5613) [details]
Quickie patch

Hmm... this is a pretty easy change, but I am a little leery -- if you
copy-and-paste the link to share w/ other editors it'll show different things
as time goes on, so it's not a stable link.

Yes, this is a common problem with the link in the new messages bar. However, the 'cur' links /are/ explicitly against the current revision - if you want a diff between this and that revision, then you can get it with the radio buttons.

(In reply to comment #3)

Created an attachment (id=5613) [details]
Quickie patch

Hmm... this is a pretty easy change, but I am a little leery -- if you
copy-and-paste the link to share w/ other editors it'll show different things
as time goes on, so it's not a stable link.

Tempted to wontfix

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

EN.WP.ST47 wrote:

Since Aaron Schulz and Brion are both tempted to wontfix, and since it would appear that no fix has been implemented, I'm going to actually do that. I would think that in most situations, when you're trying to share a link with another editor, you're more interested in a link to a diff that won't change, rather than one that remains current, and in the latter case, you can always manually edit the URL, it's a trivial edit. On the other hand, static diffs between any revision and current can be created using the radio buttons, as Mike.lifeguard said, but on the other hand once again, that only applies if the revision is on the same page as the current revision, after the first page, the cur links are the only way to do that.