Page MenuHomePhabricator

Family.ignore_certificate_error not working with requests
Closed, ResolvedPublic

Description

Family.ignore_certificate_error was a special flag to allow a family to ignore SSL certificate errors, where it was know the certificate was invalid. disable_ssl_certificate_validation was a special flag in http which achieved this.

It wasnt re-implemented when switching from httplib2->requests, and this was missed due to T101138: Certificate test can't fail as the certificate is valid.

Event Timeline

jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb subscribed.

Change 228651 had a related patch set uploaded (by VcamX):
Re-implement disable_ssl_certificate_validation

https://gerrit.wikimedia.org/r/228651

xZise already had a working patch for this (https://gerrit.wikimedia.org/r/#/c/215507), which didnt reference this task number.

Change 228651 abandoned by VcamX:
Re-implement disable_ssl_certificate_validation

Reason:
Abandoned as it's duplicated. See I0fe9023c.

https://gerrit.wikimedia.org/r/228651

Change 215507 had a related patch set uploaded (by XZise):
[FIX] http: Disable certificate validation

https://gerrit.wikimedia.org/r/215507

Change 215507 merged by jenkins-bot:
[FIX] http: Disable certificate validation

https://gerrit.wikimedia.org/r/215507

jayvdb claimed this task.
jayvdb reassigned this task from jayvdb to XZise.
jayvdb set Security to None.