Page MenuHomePhabricator

Select status of OOUI button not clear in Monobook skin
Closed, InvalidPublic

Description

When selecting yes/no when classifying some edits in Wikilabels (which uses OOUI) I couldn't see the system showing clearly whether I had changed a No to a Yes. I was learning to use Wikipedia:Labels with Gediz at Wikimania 2015 on an old Windows laptop running the Monobook skin on en.wp.

Event Timeline

Econterms raised the priority of this task from to Low.
Econterms updated the task description. (Show Details)
Econterms moved this task to Parked on the Machine-Learning-Team (Active Tasks) board.
Econterms subscribed.
Econterms renamed this task from Yes/no buttons not clear in Monobook skin to Yes/no button selections on Wikipedia:Labels page not clear in Monobook skin.Jul 16 2015, 1:02 AM
Econterms set Security to None.

I tried that in monobook. I understand it's hard to see a button is selected but that's monobook and it's an upstream issue which my guess is it won't be solved. Theses CSS designs are out of our hand:

pasted_file (768×1 px, 342 KB)

Oh, I forgot to mention that's probably a bug in OOUI

I can respect that. I don't know what should happen.

Halfak renamed this task from Yes/no button selections on Wikipedia:Labels page not clear in Monobook skin to Select status of OOjs-UI button not clear in Monobook skin.Nov 3 2016, 2:19 PM
Halfak updated the task description. (Show Details)

@Ladsgroup What is exactly meant by “selecting” here? Keyboard focus, actively pushing the button, …?

actively pushing the button (:active). I haven't checked on :focus but I'm guessing it's much worse.

@Ladsgroup Thanks! I still don't understand what the issue is exactly about, as the buttons do have a strong visual :activestate by inverting the gradient.

hmm, the problem is that they are not showing they got selected. It's a little bit difficult to explain. Let me grab an example:

pasted_file (50×127 px, 4 KB)

pasted_file (51×126 px, 4 KB)

They are clearly different but it's hard to tell which one is the active one (especially from far) and that's why it's problematic in wikilabels because we choose an option between different cases then it's hard to come back and say which one you chose. (Maybe we should've gone with RadioButton but that's another topic)

@Ladsgroup I see. Yes, that seems to be more a false choice of library widget than a flaw in the library itself. Those are not meant to be used in such context.

Volker_E renamed this task from Select status of OOjs-UI button not clear in Monobook skin to Select status of OOUI button not clear in Monobook skin.Jan 6 2018, 7:42 AM
Volker_E updated the task description. (Show Details)

Is this still relevant now that Wikilabels lives at https://labels.wmflabs.org ? It imports enwiki's vector CSS since 2016

That's right. Thanks @He7der!