Maniphest T106418

As a developer, I can easily gather code quality metrics
Closed, InvalidPublic2 Story Points
Actions

Description

This will give us the following metrics: http://docs.oclint.org/en/dev/internals/metrics.html

Add OCLint as Homebrew package dependency in Makefile
Run OCLint as part of test lane in fastlane

Related Objects

Mentioned In: T98970: iOS Continuous Integration MVP

Event Timeline

• BGerstle-WMF created this task.Jul 21 2015, 8:52 PM

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF raised the priority of this task from to Needs Triage.

• BGerstle-WMF added a project: Wikipedia-iOS-App-Backlog.

• BGerstle-WMF moved this task to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

• BGerstle-WMF added a subscriber: • BGerstle-WMF.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 8:52 PM

• BGerstle-WMF updated the task description. (Show Details)Jul 24 2015, 1:39 PM

• BGerstle-WMF set Security to None.

• BGerstle-WMF added a parent task: T93078: As a Wikipedia iOS project contributor, I can see if my changes pass tests and impact code quality metrics.

• BGerstle-WMF renamed this task from Hook up OCLint to measure code complexity to As a developer, I can easily gather code quality metrics.

• BGerstle-WMF mentioned this in T98970: iOS Continuous Integration MVP.Jul 24 2015, 1:48 PM

• BGerstle-WMF added a parent task: T98970: iOS Continuous Integration MVP.Jul 24 2015, 2:16 PM

• BGerstle-WMF moved this task from Engineering Backlog to Needs Estimation on the Wikipedia-iOS-App-Backlog board.Jul 24 2015, 6:32 PM

MBinder_WMF edited a custom field.Jul 24 2015, 6:36 PM

Fjalapeno edited projects, added Wikipedia-iOS-App-Development; removed Wikipedia-iOS-App-Backlog.Jul 27 2015, 2:11 PM

• BGerstle-WMF removed a parent task: T93078: As a Wikipedia iOS project contributor, I can see if my changes pass tests and impact code quality metrics.Jul 28 2015, 3:17 PM

• BGerstle-WMF updated the task description. (Show Details)Jul 28 2015, 5:08 PM

Ran into a number of problems while working on this:

OCLint is not available as a Homebrew package, requiring "cask" to install it as a binary package (only a minor setback, but additional complexity for devs).
This is the kicker: OCLint can't seem to compile files from our project, at least not with the following setup:

 shell
$ oclint -version
LLVM (http://llvm.org/):
  LLVM version 3.5.0svn
  Optimized build.
  Built Oct 19 2014 (09:55:19).
  Default target: x86_64-apple-darwin14.4.0
  Host CPU: core-avx2

OCLint (http://oclint.org/):
  OCLint version 0.8.1.
  Built Oct 19 2014 (10:24:44).
$ xctool -version
0.2.4

Maybe fixable by rolling back xctool and/or OCLint, but until we get more time to troubleshoot we'll have to go on w/o these metrics.

• BGerstle-WMF removed a parent task: T98970: iOS Continuous Integration MVP.Jul 28 2015, 5:10 PM

• BGerstle-WMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Development.Jul 28 2015, 5:25 PM

• BGerstle-WMF moved this task from Needs Estimation to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Jul 31 2015, 7:03 PM

MBinder_WMF added a project: WorkType-Maintenance.Aug 25 2015, 4:31 PM

• BGerstle-WMF triaged this task as Low priority.Sep 4 2015, 9:34 PM

MBinder_WMF closed this task as Invalid.Aug 8 2016, 7:28 PM

MBinder_WMF added a project: iOS-app-feature-Analytics.