Page MenuHomePhabricator

VE focus issues in REL 1_25: Unable to use the Summary and Search box
Closed, DeclinedPublic

Description

I'm currently running the REL 1_25 branch of VE. The issue I first noticed is that I was unable to use the summary box as the cursor kept reverting back to the edit layer. Several other people have noticed the same issue:

https://www.mediawiki.org/wiki/VisualEditor/Feedback#Cannot_enter_change_summary.2C_field_loses_focus_57456

https://www.mediawiki.org/wiki/VisualEditor/Feedback#Visual_Editor_Save_Page_dialog_Box_58106

After some further fiddling around I discovered that the same issue occurred if I tried to place the cursor in the search box. This seems to be some sort of issue with the edit layer itself stealing focus.

Related Objects

Event Timeline

Rosencrantz raised the priority of this task from to Needs Triage.
Rosencrantz updated the task description. (Show Details)
Rosencrantz added a project: VisualEditor.
Rosencrantz subscribed.
Aklapper renamed this task from VE focus issues in REL 1_25 to VE focus issues in REL 1_25: Unable to use the Summary and Search box.Jul 22 2015, 4:29 PM
Aklapper set Security to None.

After poking around in Chrome's debugger I managed to find that ve.debounce seems to be what's changing the focus back to the edit layer.

There's a new suggestion at https://www.mediawiki.org/w/index.php?title=Topic:Sikx3284w9gfhw6t&topic_showPostId=so4tyj3gdlz0be8q#flow-post-so4tyj3gdlz0be8q

A hacky patch:

--- extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js.old	2015-09-02 09:51:37.435374937 +0900
+++ extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js	2015-09-02 09:46:50.733371937 +0900
@@ -480,6 +480,7 @@
 					)
 				);
 			} );
+                        this.editSummaryInput.focus();
 		}, this );
 };

All it does is add a focus to the end of the getSetupProcess function call identical to the call in getReadyProcess, which seems to fix it with both recent chrome and firefox on windows and linux. It doesn't seem to be the correct solution, but it makes it work for now without any obvious problems.

Deskana subscribed.

MediaWiki 1.25 is a legacy version of MediaWiki that has not been supported for a few years now, so your recourse to fix this issue is to upgrade everything to the latest version.