Page MenuHomePhabricator

Beta: Search overlay is misplaced on iOS 8.4
Closed, ResolvedPublic

Description

The left empty space should be removed. Happening on iOS 8.4 (can be emulated on iPhone 5s).

Event Timeline

bmansurov raised the priority of this task from to Needs Triage.
bmansurov updated the task description. (Show Details)
bmansurov added a project: Readers-Web-Backlog.
bmansurov added a subscriber: bmansurov.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 10:21 PM

@Jdlrobson, I can't seem to figure out why this is happening. Do you know why?

KLans_WMF set Security to None.
KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-52-Zoolander board.

Change 226930 had a related patch set uploaded (by Jdlrobson):
Adjust how position-fixed works in light of new beta

https://gerrit.wikimedia.org/r/226930

@bmansurov luckily I have ios simulator and just connected it up to Safari and remote debugged using developer tools. Luckily this one was a logical fix :) Not sure why it doesn't show up on Chrome - is something messed up with our position fixed support?

I'm not sure either, but your fix seems to work for overlays.

Change 226930 merged by jenkins-bot:
Adjust how position-fixed works in light of new beta

https://gerrit.wikimedia.org/r/226930

Jhernandez closed this task as Resolved.Jul 29 2015, 10:01 AM
Jhernandez added a subscriber: Jhernandez.

Do we need a task for fixing this properly or is this totally done?

@Jhernandez, it may be a good idea to look into why this is happening only on iOS. Having said that, the problem is fixed, so we may delay doing so until later.

I actually think ios is doing the right thing here and my bug fix makes sense.
The header of the search is position-fixed so with the drawer open it was correctly being transformed in ios.
I think the bug is thus in in any browser that is not doing this correctly.
https://code.google.com/p/chromium/issues/detail?id=20574 < might be the cause?

Either way I'm confident we are not going to have this issue again, so it's probably not worth any extra investment in time.

lol. awesome.

the photo needs attribution. just sayin'

Macro shits-on-fire:

I'd really love to freely express myself by embedding arbitrary images, but that's not worthy it seems.