Error trying to edit Herald rules: Undefined class constant in SecurityPolicyEnforcerAction.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Jul 27 2015, 11:03 AM

Description

STEPS:

(As an admin,) Go to https://phabricator.wikimedia.org/herald/
Choose any rule that is listed
Click "Edit Rule"

ACTUAL RESULT:

>>> UNRECOVERABLE FATAL ERROR <<<
Undefined class constant &#039;VALUE_NONE&#039;
/srv/phab/libext/security/src/policy/SecurityPolicyEnforcerAction.php:28

EXPECTED RESULT:
Able to adjust Herald rules.

Details

	Subject	Repo	Branch	Lines +/-
	Adjust Herald field values to upstream changes	phabricator/extensions/security	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Aklapper	T107016 Edit Herald Rule H31 for TCB-Team
		Resolved		Aklapper	T107027 Error trying to edit Herald rules: Undefined class constant in SecurityPolicyEnforcerAction.php

Event Timeline

Aklapper created this task.Jul 27 2015, 11:03 AM

Aklapper assigned this task to • mmodell.

Aklapper raised the priority of this task from to High.

Aklapper updated the task description. (Show Details)

Aklapper added a project: Phabricator.

Aklapper added subscribers: Aklapper, • mmodell.

Restricted Application added a subscriber: scfc. · View Herald TranscriptJul 27 2015, 11:03 AM

Aklapper added a parent task: T107016: Edit Herald Rule H31 for TCB-Team.Jul 27 2015, 11:03 AM

Change 227205 had a related patch set uploaded (by Aklapper):
Adjust Herald field values to upstream changes

https://gerrit.wikimedia.org/r/227205

gerritbot added a project: Patch-For-Review.Jul 27 2015, 11:16 AM

Aklapper claimed this task.Jul 27 2015, 11:18 AM

Thinking a bit more about this, I'm not entirely sure about the consequences, so I'm temporarily restricting view access to admins. Please feel free to revert.

Aklapper changed the visibility from "Administrators" to "Public (No Login Required)".Jul 27 2015, 11:51 AM

Change 227205 merged by 20after4:
Adjust Herald field values to upstream changes

https://gerrit.wikimedia.org/r/227205

Diffusion mentioned this in rPHESc0511058ad34: Adjust Herald field values to upstream changes.Jul 27 2015, 12:01 PM

• mmodell closed this task as Resolved.Jul 27 2015, 12:09 PM

There was not any significant security consequence from this since we are no longer relying on herald for the security policy setting. The herald rule just does some sanity checking on task edits that affect the security policy. Also, this bug appears to have only affected the edit interface, not herald itself.

At any rate, thanks for catching this @Aklapper, and thanks for providing the correct patch. Very well done!

Diffusion mentioned this in rPHEXc0511058ad34: Adjust Herald field values to upstream changes.Jul 11 2018, 11:58 PM

Error trying to edit Herald rules: Undefined class constant in SecurityPolicyEnforcerAction.phpClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Error trying to edit Herald rules: Undefined class constant in SecurityPolicyEnforcerAction.php
Closed, ResolvedPublic
Actions

Related Objects
Search...