Page MenuHomePhabricator
Create Task
Maniphest T107104

Fat last modified bar in stable
Closed, ResolvedPublic
Actions

Description

Screen Shot 2015-07-27 at 4.20.36 PM.png (491×392 px, 127 KB)

This does not impact all pages but is present on certain cached pages with the following HTML...

	<div class="last-modified-bar">
	
	<div id="mw-mf-last-modified" class="truncated-text pre-content post-content">
		<a href="/wiki/Special:History/Headings"
			data-user-name=""
			data-user-gender="unknown"
			data-timestamp="1432744316">
			Last modified on 27 May 2015, at 16:31
		</a>
	</div>
</div>

Details

SubjectRepoBranchLines +/-
Modify cache conditions for replacing the last-modified-barmediawiki/extensions/MobileFrontendmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 27 2015, 11:21 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-52-Zoolander.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2015, 11:21 PM
Jdlrobson updated the task description. (Show Details)Jul 27 2015, 11:21 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
• rmoen claimed this task.Jul 27 2015, 11:38 PM
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-52-Zoolander board.
• rmoen added a comment.Jul 28 2015, 1:04 AM

I'm able to reproduce this on a mobile screen.

.pre-content and .post-content are classes that are normally applied to the parent element .last-modified-bar.
In this case, they are on the child element and the "fattness" is caused from padding being applied to .pre-content.

Still not sure why these classes are being applied incorrectly. This is perhaps due to cache?

gerritbot subscribed.Jul 28 2015, 6:05 PM

Change 227495 had a related patch set uploaded (by Robmoen):
Modify cache conditions for replacing the last-modified-bar

https://gerrit.wikimedia.org/r/227495

gerritbot added a project: Patch-For-Review.Jul 28 2015, 6:05 PM
• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-52-Zoolander board.Jul 28 2015, 6:06 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.Jul 28 2015, 6:32 PM
gerritbot added a comment.Jul 28 2015, 6:35 PM

Change 227495 merged by jenkins-bot:
Modify cache conditions for replacing the last-modified-bar

https://gerrit.wikimedia.org/r/227495

• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 28 2015, 7:00 PM
• Jhernandez closed this task as Resolved.Jul 29 2015, 9:44 AM
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-52-Zoolander board.
• Jhernandez subscribed.

Can't seem to see the fat bar no matter what I do, If you spot it re-open this with instructions on how to reproduce.

Jdlrobson mentioned this in rEMFRbda9c3f04d8f: Modify cache conditions for replacing the last-modified-bar.Jul 30 2015, 10:12 PM
Diffusion mentioned this in rMEXT8e7fba29a4c0: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 30 2015, 10:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL