Page MenuHomePhabricator

Fat last modified bar in stable
Closed, ResolvedPublic

Description


This does not impact all pages but is present on certain cached pages with the following HTML...

	<div class="last-modified-bar">
	
	<div id="mw-mf-last-modified" class="truncated-text pre-content post-content">
		<a href="/wiki/Special:History/Headings"
			data-user-name=""
			data-user-gender="unknown"
			data-timestamp="1432744316">
			Last modified on 27 May 2015, at 16:31
		</a>
	</div>
</div>

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from to High.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2015, 11:21 PM
Jdlrobson updated the task description. (Show Details)Jul 27 2015, 11:21 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-52-Zoolander board.

I'm able to reproduce this on a mobile screen.

.pre-content and .post-content are classes that are normally applied to the parent element .last-modified-bar.
In this case, they are on the child element and the "fattness" is caused from padding being applied to .pre-content.

Still not sure why these classes are being applied incorrectly. This is perhaps due to cache?

Change 227495 had a related patch set uploaded (by Robmoen):
Modify cache conditions for replacing the last-modified-bar

https://gerrit.wikimedia.org/r/227495

Change 227495 merged by jenkins-bot:
Modify cache conditions for replacing the last-modified-bar

https://gerrit.wikimedia.org/r/227495

Jhernandez closed this task as Resolved.
Jhernandez added a subscriber: Jhernandez.

Can't seem to see the fat bar no matter what I do, If you spot it re-open this with instructions on how to reproduce.