Unnecessary nowiki'ing of bare table rows
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Jul 30 2015, 10:14 PM

Description

In https://gerrit.wikimedia.org/r/#/c/227481/2/tests/parserTests-blacklist.js, @ssastry asks if the <nowiki>s are required for the table rows in,

<nowiki> </nowiki><nowiki>||</nowiki> <nowiki>||</nowiki>
<table>
<tr><td> a
</table>

Nope! This is bug.

In WEHP.escapedText, we use the tokenizer on text to determine what needs escaping. The idea being that if it tokenizes as a construct, it needs escaping. This works great except for the cases where we rely on the token stream patcher to convert tokens back to strings if they aren't in the right context (like table rows outside of tables).

The TokenStreamPatcher is a sync transformation, maybe just apply it to our token array here.

Event Timeline

Arlolra created this task.Jul 30 2015, 10:14 PM

Arlolra raised the priority of this task from to Medium.

Arlolra updated the task description. (Show Details)

Arlolra added a project: Parsoid.

Arlolra added subscribers: Arlolra, ssastry.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2015, 10:14 PM

ssastry moved this task from Needs Triage to html2wt on the Parsoid board.Dec 18 2017, 10:02 PM

Restricted Application added a subscriber: jeblad. · View Herald TranscriptDec 18 2017, 10:02 PM

ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.Sep 20 2018, 4:28 PM

ssastry moved this task from Backlog to Wikitext Escaping on the Parsoid-Edit-Support board.Sep 20 2018, 4:52 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM

subbu@earth:~/work/wmf/parsoid] cat /tmp/wt
 || ||
<table>
<tr><td> a
</table>
[subbu@earth:~/work/wmf/parsoid] php bin/parse.php --wt2wt < /tmp/wt
 || ||
<table>
<tr><td> a
</table>

Unnecessary nowiki'ing of bare table rowsClosed, ResolvedPublicActions

Description

Event Timeline

Unnecessary nowiki'ing of bare table rows
Closed, ResolvedPublic
Actions