When a cURL attempt comes back with response false and we retry it, we should log how long the failed attempt took and reset our timer. Instead, we are logging the cumulative time for all attempts in the loop. This makes it difficult to get accurate stats on a processor's API response time.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Log timing of each cURL attempt, not cumulative | mediawiki/extensions/DonationInterface | master | +14 -5 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 228186 had a related patch set uploaded (by Ejegg):
Log timing of each cURL attempt, not cumulative