Page MenuHomePhabricator

Log timing for each cURL attempt, not cumulative time
Closed, ResolvedPublic1 Story Points

Description

When a cURL attempt comes back with response false and we retry it, we should log how long the failed attempt took and reset our timer. Instead, we are logging the cumulative time for all attempts in the loop. This makes it difficult to get accurate stats on a processor's API response time.

Event Timeline

Ejegg created this task.Jul 31 2015, 12:12 AM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added a subscriber: Ejegg.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2015, 12:12 AM

Change 228186 had a related patch set uploaded (by Ejegg):
Log timing of each cURL attempt, not cumulative

https://gerrit.wikimedia.org/r/228186

Change 228186 merged by jenkins-bot:
Log timing of each cURL attempt, not cumulative

https://gerrit.wikimedia.org/r/228186

Ejegg claimed this task.Jul 31 2015, 12:51 AM
Ejegg set Security to None.
Ejegg edited a custom field.
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint The Pogues board.
Ejegg closed this task as Resolved.Aug 5 2015, 10:06 PM
Ejegg removed a project: Fundraising-Backlog.