Page MenuHomePhabricator

Remove url parameters when getting DOI from URL
Closed, ResolvedPublic

Description

Request:

http://www.jstor.org/discover/10.1086/378695?uid=3739832&uid=2&uid=4&uid=3739256&sid=21105503736473

Fails to get the metadata from the doi because it includes the parameters as part of the regex-ed doi. We should parse the url to remove the params before looking for a doi.

Event Timeline

Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz moved this task to IO Tasks on the Citoid board.
Mvolz subscribed.
Mvolz triaged this task as High priority.
Mvolz set Security to None.

Change 232259 had a related patch set uploaded (by Mvolz):
[WIP] Remove query parameters before getting doi

https://gerrit.wikimedia.org/r/232259

Change 232259 merged by Mobrovac:
Improve DOI detection

https://gerrit.wikimedia.org/r/232259

mobrovac subscribed.

Deployed, resolving.