"Redis::publish requires at least 2 parameters 2 given"
Closed, ResolvedPublic

Description

I realize that error message doesn't make any sense, but that's what it says:

From fluorine:

mattflaschen@fluorine:/a/mw-log$ grep -A 3 'Redis::publish requires at least 2 param' hhvm.log 
Aug 18 19:05:03 mw1133:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 19:05:03 mw1133:  #012Notice: JobQueueGroup::__destruct: 7 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 18 19:05:03 mw1133:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 15 00:53:38 mw1114:  message repeated 5 times: [ Lost parent, LightProcess exiting]
--
Aug 18 20:37:26 mw1017:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf19/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 20:37:26 mw1017:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (Flow\Repository\UserName\TwoStepUserNameQuery::execute)). in /srv/mediawiki/php-1.26wmf19/includes/db/Database.php on line 4277
Aug 18 20:37:26 mw1017:  #012Notice: JobQueueGroup::__destruct: 5 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf19/includes/jobqueue/JobQueueGroup.php on line 420
--
Aug 18 22:29:19 mw1017:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf19/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 22:29:19 mw1017:  #012Notice: JobQueueGroup::__destruct: 5 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf19/includes/jobqueue/JobQueueGroup.php on line 420
Aug 18 22:29:19 mw1017:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (Flow\Repository\UserName\TwoStepUserNameQuery::execute)). in /srv/mediawiki/php-1.26wmf19/includes/db/Database.php on line 4277
--
Aug 19 00:46:48 mw1012:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:46:51 mw1138:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:46:51 mw1138:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 00:46:51 mw1138:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285
Aug 19 00:46:51 mw1138:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
--
Aug 19 00:56:05 mw1189:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:56:05 mw1189:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 19 00:56:05 mw1189:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 00:56:05 mw1189:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285
--
Aug 19 01:09:50 mw1195:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 01:09:50 mw1195:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 19 01:09:50 mw1195:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 01:09:50 mw1195:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 1:19 AM
Mattflaschen-WMF set Security to None.

Change 232435 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232435

Change 232435 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232435

Change 232436 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232436

Change 232437 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232437

Change 232436 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232436

Change 232437 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232437

Checked in betalabs

DannyH closed this task as Resolved.Aug 25 2015, 4:47 PM
DannyH added a subscriber: DannyH.

Note: https://github.com/facebook/hhvm/issues/6062 has also been addressed upstream by allowing null parameters.