Page MenuHomePhabricator
Create Task
Maniphest T109544

"Redis::publish requires at least 2 parameters 2 given"
Closed, ResolvedPublic
Actions

Description

I realize that error message doesn't make any sense, but that's what it says:

From fluorine:

mattflaschen@fluorine:/a/mw-log$ grep -A 3 'Redis::publish requires at least 2 param' hhvm.log 
Aug 18 19:05:03 mw1133:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 19:05:03 mw1133:  #012Notice: JobQueueGroup::__destruct: 7 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 18 19:05:03 mw1133:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 15 00:53:38 mw1114:  message repeated 5 times: [ Lost parent, LightProcess exiting]
--
Aug 18 20:37:26 mw1017:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf19/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 20:37:26 mw1017:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (Flow\Repository\UserName\TwoStepUserNameQuery::execute)). in /srv/mediawiki/php-1.26wmf19/includes/db/Database.php on line 4277
Aug 18 20:37:26 mw1017:  #012Notice: JobQueueGroup::__destruct: 5 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf19/includes/jobqueue/JobQueueGroup.php on line 420
--
Aug 18 22:29:19 mw1017:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf19/includes/clientpool/RedisConnectionPool.php on line 483
Aug 18 22:29:19 mw1017:  #012Notice: JobQueueGroup::__destruct: 5 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf19/includes/jobqueue/JobQueueGroup.php on line 420
Aug 18 22:29:19 mw1017:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (Flow\Repository\UserName\TwoStepUserNameQuery::execute)). in /srv/mediawiki/php-1.26wmf19/includes/db/Database.php on line 4277
--
Aug 19 00:46:48 mw1012:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:46:51 mw1138:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:46:51 mw1138:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 00:46:51 mw1138:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285
Aug 19 00:46:51 mw1138:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
--
Aug 19 00:56:05 mw1189:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 00:56:05 mw1189:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 19 00:56:05 mw1189:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 00:56:05 mw1189:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285
--
Aug 19 01:09:50 mw1195:  #012Fatal error: Redis::publish requires at least 2 parameters 2 given in /srv/mediawiki/php-1.26wmf18/includes/clientpool/RedisConnectionPool.php on line 483
Aug 19 01:09:50 mw1195:  #012Notice: JobQueueGroup::__destruct: 3 buffered job(s) of type(s) RestbaseUpdateJob, RecentChangesUpdateJob never inserted. in /srv/mediawiki/php-1.26wmf18/includes/jobqueue/JobQueueGroup.php on line 420
Aug 19 01:09:50 mw1195:  #012Notice: Uncommitted DB writes (transaction from DatabaseBase::query (LinkCache::addLinkObj)). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4277
Aug 19 01:09:50 mw1195:  #012Notice: DB transaction callbacks still pending (from EmailNotification::updateWatchlistTimestamp). in /srv/mediawiki/php-1.26wmf18/includes/db/Database.php on line 4285

Details

SubjectRepoBranchLines +/-
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)mediawiki/corewmf/1.26wmf19+9 -1
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)mediawiki/corewmf/1.26wmf18+9 -1
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)mediawiki/coremaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Aug 19 2015, 1:19 AM
• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a project: MediaWiki-Core-JobQueue.
• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, aaron.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 1:19 AM
• Mattflaschen-WMF added a comment.Aug 19 2015, 1:40 AM

See https://github.com/facebook/hhvm/issues/6062 and https://github.com/facebook/hhvm/blob/a84eda43a3cd7f28ff5dce26f13b316e6d9c4e7b/hphp/system/php/redis/Redis.php#L1550 for the reason for the misleading error message.

• Mattflaschen-WMF updated the task description. (Show Details)Aug 19 2015, 1:47 AM
• Mattflaschen-WMF set Security to None.
gerritbot subscribed.Aug 19 2015, 2:58 AM

Change 232435 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232435

gerritbot added a project: Patch-For-Review.Aug 19 2015, 2:58 AM
gerritbot added a comment.Aug 19 2015, 3:24 AM

Change 232435 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232435

• Mattflaschen-WMF mentioned this in rMW047fc253d04f: RC: Handle getLine returning null, which breaks Redis engine (at least HHVM).Aug 19 2015, 3:25 AM
• Mattflaschen-WMF mentioned this in T109549: Revisit how we exclude things from RC.Aug 19 2015, 3:26 AM
gerritbot added a comment.Aug 19 2015, 3:27 AM

Change 232436 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232436

gerritbot added a comment.Aug 19 2015, 3:27 AM

Change 232437 had a related patch set uploaded (by Mattflaschen):
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232437

gerritbot added a comment.Aug 19 2015, 3:37 AM

Change 232436 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232436

gerritbot added a comment.Aug 19 2015, 3:37 AM

Change 232437 merged by jenkins-bot:
RC: Handle getLine returning null, which breaks Redis engine (at least HHVM)

https://gerrit.wikimedia.org/r/232437

• Mattflaschen-WMF mentioned this in rMWb5075957f034: RC: Handle getLine returning null, which breaks Redis engine (at least HHVM).Aug 19 2015, 3:37 AM
• Mattflaschen-WMF mentioned this in rMWc257a8b45b37: RC: Handle getLine returning null, which breaks Redis engine (at least HHVM).
• Mattflaschen-WMF mentioned this in T108396: New flow topics not appearing in watchlist.Aug 19 2015, 3:53 AM
• Mattflaschen-WMF edited projects, added MediaWiki-Recent-changes; removed MediaWiki-Core-JobQueue.
• Mattflaschen-WMF added a project: Collaboration-Team-Archive-2015-2016.
• Mattflaschen-WMF claimed this task.Aug 19 2015, 3:57 AM
• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-18_(1.26wmf19), WMF-deploy-2015-08-25_(1.26wmf20), WMF-deploy-2015-08-11_(1.26wmf18).Aug 19 2015, 7:02 AM
• DannyH added a project: Essential-Work.Aug 21 2015, 11:15 PM
Etonkovidova subscribed.Aug 24 2015, 9:11 PM

Checked in betalabs

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 24 2015, 9:11 PM
• DannyH closed this task as Resolved.Aug 25 2015, 4:47 PM
• DannyH subscribed.
• Mattflaschen-WMF added a comment.Aug 29 2015, 2:46 AM

Note: https://github.com/facebook/hhvm/issues/6062 has also been addressed upstream by allowing null parameters.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL