| Nemo_bis | |
| Aug 20 2015, 9:39 AM |
| F2575207: dashiki-rolling-holes.png | |
| Sep 12 2015, 12:10 PM |
| F12: project.png | |
| Sep 10 2015, 3:20 PM |
| F2564210: vital-sidebar.png | |
| Sep 10 2015, 7:36 AM |
| F1910722: vital.png | |
| Aug 20 2015, 9:39 AM |
https://vital-signs.wmflabs.org/#projects=ruwiki,itwiki,dewiki,frwiki,eswiki,jawiki/metrics=Pageviews doesn't load anything, only says «Please select a metric above And projects from the left».
https://vital-signs.wmflabs.org/#projects=ruwiki,itwiki,dewiki,frwiki,eswiki,jawiki/metrics=LegacyPageviews works.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix date parsing in Firefox | analytics/dashiki | master | +9 -8 |
What Browser and version is this? I'm trying to find out if it's a race condition or a browser bug. It works ok for me in Firefox 39 and Chrome 44.0.2403.130 (64-bit) and I haven't seen any race condition lately.
Firefox 39 here (firefox-39.0-8.fc21.x86_64 for the sake of precision).
The only error I see in the console is "TypeError: e.color is not a function", which doesn't present itself in the functioning graph.
Thanks Nemo, that's very useful, will try to track down after some other urgent matters.
@Nemo_bis, that bug was fixed a while back, can you clear your cache for vital-signs and try again?
@Jdforrester-WMF, mind trying that also? Clearing your cache?
We've gotta update the cache headers config in apache to fix that problem, but I'm just making sure there's not another bug happening.
Currently vital-signs.wmflabs.org doesn't load at all for me, blank page. I'll retry later.
@Nemo_bis, I'm just making sure, you have the same issue despite clearing your cache? I tried it with the version of Firefox you mentioned and I didn't have an issue.
Yes, with the difference that sometimes the sidebar doesn't load any longer (I had to hard refresh a few times). Disabling AdBlock Plus and NoScript had no effect.
@Nemo_bis - I deployed some caching config changes and fixed a bug in the build that was causing some unwanted caching as well. If you try it again, could you first open up the developer console (F12 on my linux machine) and look at the Network tab while the page is loading? If you see it loading "project-selector-85b353f.js" and it's still not working, then I'm thinking of flying to meet with you to figure this out :)
Great, pageviews works for me now with firefox-40.0.3-1.fc22.x86_64; will test on the other machine now.
However, I now get on other graphs things such as:
Can't plot empty data set: dygraphs-timeseries-85b353f.js:3:21716 "Fri, 11 Sep 2015 10:14:29 GMT https://vital-signs.wmflabs.org/dygraphs-timeseries-85b353f.js:5 TypeError: a is null"
Heh, thanks Nemo. There are two issues here. First, someone broke our config pages, which is totally my fault because I should make a custom Dashiki namespace instead of polluting Main. I opened that up as a separate issue: T112268. And second is another issue with dygraphs in firefox, which I'll find a workaround for and deploy soon. I'm glad that nasty caching problem's not happening any more, thanks for all the feedback.
Change 237664 had a related patch set uploaded (by Milimetric):
Fix date parsing in Firefox
Thanks again, @Nemo_bis, all seems well in Firefox land now. It was just handling dates in stubborn bizarre ways :)
Thanks, all graphs seem to work now. Several of them seem to be missing some data, unrelated?
The missing data is due to labs being inadequately powerful to run all the metrics we're trying to run on it. Also, these metrics are sometimes too computationally intensive. This next quarter we're going to tackle both of those problems.