Page MenuHomePhabricator

serializeChildrenToString should maybe be using its own wts and state
Open, MediumPublic

Description

From https://gerrit.wikimedia.org/r/#/c/232835/

Need to verify that nothing from the global state is needed for this cleanup.

Event Timeline

Arlolra raised the priority of this task from to Medium.
Arlolra updated the task description. (Show Details)
Arlolra added a subscriber: Arlolra.

Looking at this a bit today, one obvious piece of state that needs to be ported is the hasQuoteNowikis and hasIndentPreNowikis that get set.

Change 640954 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Reset slc before serializeChildrenToString

https://gerrit.wikimedia.org/r/640954

Change 640954 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Reset slc before serializeChildrenToString

https://gerrit.wikimedia.org/r/640954

Change 641308 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308

Change 641308 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308