serializeChildrenToString should maybe be using its own wts and state
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Arlolra
	Aug 20 2015, 11:26 PM

Description

From https://gerrit.wikimedia.org/r/#/c/232835/

Need to verify that nothing from the global state is needed for this cleanup.

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.13.0-a17	mediawiki/vendor	master	+750 -431
	Reset slc before serializeChildrenToString	mediawiki/services/parsoid	master	+10 -16

Customize query in gerrit

Related Objects

Mentioned In: rGPAR6adcd9daf8f7: serializeChildrenToString shouldn't clobber sol state

Event Timeline

Arlolra created this task.Aug 20 2015, 11:26 PM

Arlolra raised the priority of this task from to Medium.

Arlolra updated the task description. (Show Details)

Arlolra added projects: Parsoid, Parsoid-Serializer.

Arlolra subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2015, 11:26 PM

Arlolra mentioned this in rGPAR6adcd9daf8f7: serializeChildrenToString shouldn't clobber sol state.Aug 21 2015, 2:49 PM

Looking at this a bit today, one obvious piece of state that needs to be ported is the hasQuoteNowikis and hasIndentPreNowikis that get set.

ssastry moved this task from Needs Triage to html2wt on the Parsoid board.Dec 18 2017, 10:02 PM

ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.Sep 20 2018, 4:28 PM

ssastry moved this task from Backlog to Tech Debt / Big changes on the Parsoid-Edit-Support board.Sep 20 2018, 4:59 PM

Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM

ssastry moved this task from html2wt to Tech Debt / Big changes on the Parsoid board.Mar 5 2020, 10:20 PM

Change 640954 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Reset slc before serializeChildrenToString

https://gerrit.wikimedia.org/r/640954

gerritbot added a project: Patch-For-Review.Nov 13 2020, 4:43 PM

Change 640954 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Reset slc before serializeChildrenToString

https://gerrit.wikimedia.org/r/640954

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2020, 5:10 PM

Change 641308 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17

https://gerrit.wikimedia.org/r/641308

gerritbot added a project: Patch-For-Review.Nov 17 2020, 1:09 AM

Change 641308 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a17