Page MenuHomePhabricator

Status of watched page not shown correctly due to caching
Closed, ResolvedPublic

Description

The status whether a page is watched or not is not shown correctly in the interface, as the page gets cached in the old version.

Steps to reproduce:

  1. Visit a page on en.wikipedia you currently don't watch, clear your caches.
  2. Click the star to watch it. The star turns blue (in Vector, in other skins the text of the watch tab changes), a message is shown that you now watch it, you can confirm this on https://en.wikipedia.org/wiki/Special:EditWatchlist.
  3. Click the "Article" tab.

Expected result: The star is still blue.
Actual result: The page is sent as 304 Not Modified, a cached version is shown which looks like you are not watching the page. You can confirm on https://en.wikipedia.org/wiki/Special:EditWatchlist that you still watch the page.

  1. Reload the page in a way that clears the cache. The watch star now turns blue as expected.
  2. Click the star to unwatch the page. The star turns white.
  3. Click the "Article" tab.

Expected result: The star is still white.
Actual result: Again, the page is sent as 304 Not Modified, the star is blue. Clearing the cache fixes the display, but shouldn't be necessary.

Event Timeline

Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark subscribed.

@Schnark: I cannot reproduce this problem with the given steps in Chromium 46 with a random en.wp article. Which browser is this about, which site to test with, and does this still happen?

Schnark claimed this task.

I can't reproduce this any longer, either, so somebody fixed this bug without knowing about it.

CCing aaron, since he seems to have worked on caching issues recently a lot. When you really fixed this, you might want to claim this task and get praised for it.