That’s weird: the template Zabytki wiersz is mainly transcluded in namespace Wikiprojekt, whose number is 102…

Also, this is the old-pl config, there is also a pl.

@Multichill, @Effeietsanders, would you know more about this − or would you know who might know more about this?

Problem is bigger than I thought >_>

I dunno how all the -old tables came in there. You would have to check the git history for that. Best steps: 1. Check if the template still exists and if it still has transclusions. 2. If it's not used, just remove the source, if it's used, switch the namespace.

Hi! The database of Russian monuments needs to be modified. The country "ru-old" is no longer needed. These lists are obsolete, and I am not sure that they even exist. The rules for the country "ru" are outdated as well.

Up-to-date Russian lists are located at https://ru.wikivoyage.org/wiki/Культурное наследие России/ (most of the lists are subpages). The lists are organized using the {{monument}} template. If necessary, I can provide the mapping of template's parameters onto the fields that the bot reads.

Fine print: this year we also have the lists of Crimean monuments that are organized as subpages of https://ru.wikivoyage.org/wiki/Культурное наследие/
The country name is omitted in the pagetitle in order to avoid the delicate issue of which state Crimea belongs to. These lists could be uploaded into the database as well, although they are mostly repeating Ukrainian lists, so there will be lots of overlaps. Skipping the Crimean lists for the time being can also be a solution.

So, the namespace error is fixed? What is the new error now? Which countries are affected?

The harvesting of Russian monuments is in a separate task now:
https://phabricator.wikimedia.org/T110665

...but I do not see much activity there=(

Where is the code for erfgoed bot? I want to check it.

In T110497#1593351, @Emijrp wrote:

MariaDB [s51138__heritage_p]> select count(*) from monuments_all where lang='es' and country='es';
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

Yes. Here is what happens: when running the update for all countries, the ones listed in T110420 crash right on. This causes the table for that country to be reinitialised to 0. This bug does *not* happen when running the bot on this country only (which I did a couple of times, see P1940). This puzzles me greatly.

@Emijrp, do note that when/even if I manage to get these countries working as part of the full run, the issues listed in P1940 will persist (I’m thinking of the 277 missing primkeys)

In T110420#1593372, @Emijrp wrote:

Where is the code for erfgoed bot? I want to check it.

In Gerrit : http://git.wikimedia.org/tree/labs%2Ftools%2Fheritage.git

Try changing line 482 in update_database.py from:

filteredGen = pagegenerators.NamespaceFilterPageGenerator(
        transGen, countryconfig.get('namespaces'))

to:

filteredGen = pagegenerators.NamespaceFilterPageGenerator(
        transGen, countryconfig.get('namespaces'), site=site)

Change 235260 had a related patch set uploaded (by Jean-Frédéric):
Specify site to use when specifying NamespaceFilterPageGenerator

https://gerrit.wikimedia.org/r/235260

Change 235260 merged by Jean-Frédéric:
Specify site to use when specifying NamespaceFilterPageGenerator

https://gerrit.wikimedia.org/r/235260

In T110420#1593393, @Emijrp wrote:

Try changing line 482 in update_database.py from:
[snip]

Thanks! Merged. I’m rescheduling an update in a short bit.

@Emijrp, do note that when/even if I manage to get these countries working as part of the full run, the issues listed in P1940 will persist (I’m thinking of the 277 missing primkeys)

@JeanFred The missing primkeys error is due to empty cells in the Spanish lists, not a bot error. So, it will be solved when wikipedians improve the tables.

In T110420#1593491, @Emijrp wrote:

@Emijrp, do note that when/even if I manage to get these countries working as part of the full run, the issues listed in P1940 will persist (I’m thinking of the 277 missing primkeys)

@JeanFred The missing primkeys error is due to empty cells in the Spanish lists, not a bot error. So, it will be solved when wikipedians improve the tables.

I know :) I suspected that these primkeys missing might be partially reponsible for (es) monuments missing − but that was silly of me, 277 is not that much compared to the number of monuments in Spain (which I do not know, but imagine bigger than that ;)

In T110420#1593490, @JeanFred wrote:

In T110420#1593393, @Emijrp wrote:

Try changing line 482 in update_database.py from:
[snip]

Thanks! Merged. I’m rescheduling an update in a short bit.

Job in progress. Will take a while. I will monitor it a bit to see if this issue is now fixed.

In T110420#1593523, @JeanFred wrote:

In T110420#1593490, @JeanFred wrote:

In T110420#1593393, @Emijrp wrote:

Try changing line 482 in update_database.py from:
[snip]

Thanks! Merged. I’m rescheduling an update in a short bit.

Job in progress. Will take a while. I will monitor it a bit to see if this issue is now fixed.

Harvesting is going well. Closing this as Resolve. Thanks Emilio for finding the bug!

I don't see the Spain monuments in the map yet. https://tools.wmflabs.org/wlm-maps/#9/40.2387/-3.7189

In T110420#1595026, @Emijrp wrote:

I don't see the Spain monuments in the map yet. https://tools.wmflabs.org/wlm-maps/#9/40.2387/-3.7189

OK! Now it is working, yay! Finally.

Spain https://tools.wmflabs.org/wlm-maps/#10/40.3596/-3.7202
Poland https://tools.wmflabs.org/wlm-maps/#7/53.262/20.687
Italy https://tools.wmflabs.org/wlm-maps/#8/40.231/16.199
Bolivia https://tools.wmflabs.org/wlm-maps/#6/-16.397/-63.549
Mexico https://tools.wmflabs.org/wlm-maps/#8/19.244/-99.619
Chile https://tools.wmflabs.org/wlm-maps/#5/-36.862/-81.519
Sweden https://tools.wmflabs.org/wlm-maps/#7/59.571/16.809
Russia https://tools.wmflabs.org/wlm-maps/#6/55.323/41.902
Colombia https://tools.wmflabs.org/wlm-maps/#13/4.6013/-74.0765
Panama https://tools.wmflabs.org/wlm-maps/#8/8.455/-80.096
Argentina https://tools.wmflabs.org/wlm-maps/#10/-34.6219/-58.7274

Uruguay and Venezuela are empty. No coords perhaps?

May I remind you that the settings for the Russian monuments should be modified? Even if the harvesting works with the old settings, it makes little sense for us, because the majority of coordinates are wrong. Some objects are shifted from Central Russia to the Pacific coast, and so on. We should use current lists for harvesting, not some old outdated stuff.

If changing the settings is not possible at the moment, I would rather remove Russian monuments from the database completely because we should not send our participants to wrong places asking them to take photos of buildings that are not cultural heritage or do not exist at all.

@JeanFred Can you change the Russian config from Wikipedia to Wikivoyage? https://phabricator.wikimedia.org/T110665

@JeanFred The monuments_all table doesn't exist right now!