Page MenuHomePhabricator

Fix problems reported by RuboCop in Math
Closed, ResolvedPublic

Details

Related Gerrit Patches:
mediawiki/extensions/Math : masterFixed Style/StringLiterals RuboCop offense
mediawiki/extensions/Math : masterFixed Style/SpaceInsideHashLiteralBraces RuboCop offense
mediawiki/extensions/Math : masterFixed Style/SpaceAroundOperators RuboCop offense

Event Timeline

zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added subscribers: dduvall, zeljkofilipin.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 2:42 PM

Change 235476 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/235476

Change 235477 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/235477

Change 235478 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/235478

Woudn't it be easier to combine all commits to one?

@Physikerwelt: I prefer small commits. If you prefer one larger commit, let me know.

Change 235476 merged by jenkins-bot:
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/235476

Change 235477 merged by jenkins-bot:
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/235477

Change 235478 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/235478

zeljkofilipin closed this task as Resolved.Sep 22 2015, 8:03 PM