Page MenuHomePhabricator
Create Task
Maniphest T111184

Fix problems reported by RuboCop in Math
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/StringLiterals RuboCop offensemediawiki/extensions/Mathmaster+13 -29
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offensemediawiki/extensions/Mathmaster+1 -7
Fixed Style/SpaceAroundOperators RuboCop offensemediawiki/extensions/Mathmaster+1 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Sep 2 2015, 2:42 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a project: Browser-Tests-Infrastructure.
zeljkofilipin added subscribers: dduvall, zeljkofilipin.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 2:42 PM
zeljkofilipin moved this task from Inbox to In Progress on the Browser-Tests-Infrastructure board.Sep 2 2015, 2:42 PM
gerritbot subscribed.Sep 2 2015, 3:21 PM

Change 235476 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/235476

gerritbot added a project: Patch-For-Review.Sep 2 2015, 3:21 PM

Change 235477 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/235477

gerritbot added a comment.Sep 2 2015, 3:21 PM

Change 235478 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/235478

zeljkofilipin moved this task from In Progress to Waiting on the Browser-Tests-Infrastructure board.Sep 2 2015, 3:25 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 11 2015, 3:28 PM
Physikerwelt subscribed.Sep 17 2015, 1:10 PM

Woudn't it be easier to combine all commits to one?

zeljkofilipin added a comment.Sep 17 2015, 1:43 PM

@Physikerwelt: I prefer small commits. If you prefer one larger commit, let me know.

gerritbot added a comment.Sep 22 2015, 5:27 PM

Change 235476 merged by jenkins-bot:
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/235476

zeljkofilipin mentioned this in rMEXT5863c82f3851: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Sep 22 2015, 5:27 PM
dduvall mentioned this in rEMAT4e4baedb2b49: Fixed Style/SpaceAroundOperators RuboCop offense.Sep 22 2015, 5:27 PM
gerritbot added a comment.Sep 22 2015, 5:34 PM

Change 235477 merged by jenkins-bot:
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/235477

gerritbot added a comment.Sep 22 2015, 5:34 PM

Change 235478 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/235478

dduvall mentioned this in rEMAT2bda4398f460: Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense.Sep 22 2015, 5:34 PM
dduvall mentioned this in rEMAT646fc8e94bf5: Fixed Style/StringLiterals RuboCop offense.
zeljkofilipin mentioned this in rMEXTf54949d290be: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Sep 22 2015, 5:34 PM
zeljkofilipin mentioned this in rMEXT1c1804552284: Updated mediawiki/extensions Project: mediawiki/extensions/Math….
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 22 2015, 6:00 PM
zeljkofilipin closed this task as Resolved.Sep 22 2015, 8:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits