Page MenuHomePhabricator

[Regression pre-wmf22] Cancelling link inspector crashes VE
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

1.Open a page with VE
2.Open the link inspector
3.While the inspector is open, click on the Cite option

Observed Result:
Ve crashes and the following error appears in the console:
TypeError: data is undefined

Event Timeline

Ryasmeen created this task.Sep 2 2015, 7:41 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added a subscriber: Ryasmeen.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 7:41 PM
Jdforrester-WMF triaged this task as High priority.Sep 2 2015, 7:42 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Krenair added a subscriber: Krenair.Sep 2 2015, 7:46 PM

I get Uncaught TypeError: Cannot read property 'convert' of undefined

Krenair renamed this task from [Regression pre-wmf22] Clicking on any other option from the toolbar while the link inspector is open crashes VE to [Regression pre-wmf22] Cancelling link inspector crashes VE.Sep 2 2015, 8:20 PM

Change 235613 had a related patch set uploaded (by Alex Monk):
Don't break when you cancel the link inspector

https://gerrit.wikimedia.org/r/235613

Change 235613 merged by jenkins-bot:
Don't break when you cancel the link inspector

https://gerrit.wikimedia.org/r/235613

Jdforrester-WMF closed this task as Resolved.Sep 2 2015, 9:17 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.