Page MenuHomePhabricator
Create Task
Maniphest T111241

[Regression pre-wmf22] Cancelling link inspector crashes VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open a page with VE
2.Open the link inspector
3.While the inspector is open, click on the Cite option

Observed Result:
Ve crashes and the following error appears in the console:
TypeError: data is undefined

Screen Shot 2015-09-02 at 12.34.35 PM.png (603×1 px, 97 KB)

Details

SubjectRepoBranchLines +/-
Don't break when you cancel the link inspectormediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Sep 2 2015, 7:41 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 7:41 PM
Jdforrester-WMF triaged this task as High priority.Sep 2 2015, 7:42 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Krenair subscribed.Sep 2 2015, 7:46 PM

I get Uncaught TypeError: Cannot read property 'convert' of undefined

Krenair renamed this task from [Regression pre-wmf22] Clicking on any other option from the toolbar while the link inspector is open crashes VE to [Regression pre-wmf22] Cancelling link inspector crashes VE.Sep 2 2015, 8:20 PM
gerritbot subscribed.Sep 2 2015, 8:31 PM

Change 235613 had a related patch set uploaded (by Alex Monk):
Don't break when you cancel the link inspector

https://gerrit.wikimedia.org/r/235613

gerritbot added a project: Patch-For-Review.Sep 2 2015, 8:31 PM
Krenair claimed this task.Sep 2 2015, 8:32 PM

Caused by https://gerrit.wikimedia.org/r/#/c/233669/11/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js

gerritbot added a comment.Sep 2 2015, 9:10 PM

Change 235613 merged by jenkins-bot:
Don't break when you cancel the link inspector

https://gerrit.wikimedia.org/r/235613

Krenair mentioned this in rEVED7c2f6e1f5f7a: Don't break when you cancel the link inspector.Sep 2 2015, 9:11 PM
Jdforrester-WMF closed this task as Resolved.Sep 2 2015, 9:17 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-09-08_(1.26wmf22); removed Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Ryasmeen added a project: Verified-in-Phase0.Sep 3 2015, 12:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL