Page MenuHomePhabricator
Create Task
Maniphest T111342

[Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS
Closed, ResolvedPublic
Actions

Description

when running tests locally...

php phpunit.php ../../extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php 
PHPUnit already present
PHPUnit 3.7.37 by Sebastian Bergmann.

Configuration read from /var/www/wiki/w/tests/phpunit/suite.xml

....F........

Time: 27.84 seconds, Memory: 65.36Mb

There was 1 failure:

1) Wikibase\Test\WikiPageEntityStoreTest::testSaveRedirect
null does not match expected type "object".

/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php:588
/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php:248
/var/www/wiki/w/tests/phpunit/MediaWikiTestCase.php:131

Details

SubjectRepoBranchLines +/-
Fix WikiPageEntityRedirectLookup::getRedirectForEntityId for items in main NSmediawiki/extensions/Wikibasemaster+71 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

aude created this task.Sep 3 2015, 12:54 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 12:54 PM
aude updated the task description. (Show Details)Sep 3 2015, 12:54 PM
aude set Security to None.
aude added a parent task: T111343: [Bug] wikibase phpunit failures.Sep 3 2015, 12:58 PM
aude added a comment.Sep 3 2015, 1:16 PM

also:

46) Wikibase\Test\WikiPageEntityRedirectLookupTest::testGetRedirectForEntityId
null does not match expected type "object".

/var/www/wiki/w/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/store/sql/WikiPageEntityRedirectLookupTest.php:68
/var/www/wiki/w/tests/phpunit/MediaWikiTestCase.php:131
aude added a comment.Sep 3 2015, 2:53 PM

the problem happens with items in the main namespace.

I have a fix (trivial), but also am working on adding tests for this.

aude added a comment.Sep 3 2015, 4:44 PM

https://gerrit.wikimedia.org/r/#/c/235757/

aude claimed this task.Sep 3 2015, 4:44 PM
aude triaged this task as Medium priority.
aude added a project: Patch-For-Review.
aude renamed this task from [Bug] WikiPageEntityStoreTest::testSaveRedirect test failure to [Bug] WikiPageEntityRedirectLookup::getRedirectForEntityId does not work correctly for items in main NS.Sep 3 2015, 4:57 PM
aude added a project: Wikidata-Sprint-2015-09-01.
aude moved this task from Backlog to Review on the Wikidata-Sprint-2015-09-01 board.
gerritbot subscribed.Sep 4 2015, 10:32 AM

Change 235757 merged by jenkins-bot:
Fix WikiPageEntityRedirectLookup::getRedirectForEntityId for items in main NS

https://gerrit.wikimedia.org/r/235757

Diffusion mentioned this in rMEXT3ce1790795c3: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 4 2015, 10:32 AM
aude mentioned this in rEWBAe7e599817080: Fix WikiPageEntityRedirectLookup::getRedirectForEntityId for items in main NS.Sep 4 2015, 10:32 AM
Lydia_Pintscher closed this task as Resolved.Sep 4 2015, 10:52 AM
Lydia_Pintscher moved this task from Review to Done on the Wikidata-Sprint-2015-09-01 board.
Lydia_Pintscher subscribed.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Sep 8 2015, 9:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits