Page MenuHomePhabricator
Create Task
Maniphest T111738

extensions/Thanks - file permissions trigger debian lintian warnings
Closed, ResolvedPublic
Actions

Description

0) Context

DEB packages of mediawiki and many of its extensions, are prepared as part of the WP-MIRROR project.
See https://www.mediawiki.org/wiki/Wp-mirror.

  1. Lintian

During the build process, lintian performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When lintian sees a shell script with 644 permissions, rather than 755, lintian will throw a warning like:

W: wp-mirror-mediawiki: script-not-executable usr/share/wp-mirror-mediawiki/extensions/Thanks/scripts/pre-commit

  1. Files which should have permissions set to 755

extensions/Thanks/scripts/pre-commit

  1. Technical details

DEB standards version: 3.9.6
GIT branch: master

Details

SubjectRepoBranchLines +/-
Permission file problem.mediawiki/extensions/Thanksmaster+0 -0
Customize query in gerrit

Related Objects

Event Timeline

wpmirrordev created this task.Sep 7 2015, 11:00 PM
wpmirrordev assigned this task to kaldari.
wpmirrordev raised the priority of this task from to Medium.
wpmirrordev updated the task description. (Show Details)
wpmirrordev added projects: Thanks, good first task.
wpmirrordev subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 7 2015, 11:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
wpmirrordev renamed this task from extension/Thanks - file permissions trigger debian lintian warnings to extensions/Thanks - file permissions trigger debian lintian warnings.Sep 7 2015, 11:22 PM
wpmirrordev set Security to None.
xSavitar subscribed.Sep 19 2015, 5:03 AM

Hey, this seems to be a kind of simple bug i guess. I will like to work on this bug and will like to know a step to move ahead. Any help will be appreciated. Is the bug still open to be worked on?

xSavitar added a comment.Sep 19 2015, 5:07 AM

Ohhh, i did not even check. It has been assigned already. :)

Aklapper added a comment.Sep 19 2015, 8:15 AM
In T111738#1655511, @D3r1ck01 wrote:

It has been assigned already. :)

@D3r1ck01: @wpmirrordev assigned this to @kaldari but I am sure that you could still this task from him! Looking forward to your patch in Wikimedia Gerrit!

kaldari added a comment.Sep 21 2015, 7:53 PM

@D3r1ck01: Go for it! Looks like it's just a permissions change, so should be pretty straightforward :)

kaldari reassigned this task from kaldari to xSavitar.Sep 21 2015, 7:54 PM
gerritbot subscribed.Sep 22 2015, 11:10 AM

Change 240071 had a related patch set uploaded (by D3r1ck01):
Permission file problem.

https://gerrit.wikimedia.org/r/240071

gerritbot added a project: Patch-For-Review.Sep 22 2015, 11:10 AM
gerritbot added a comment.Sep 22 2015, 11:25 AM

Change 240071 merged by jenkins-bot:
Permission file problem.

https://gerrit.wikimedia.org/r/240071

xSavitar mentioned this in rETHA1336c386882c: Permission file problem..Sep 22 2015, 11:25 AM
xSavitar mentioned this in rMEXTf26a0b34cde5: Updated mediawiki/extensions Project: mediawiki/extensions/Thanks….
JanZerebecki closed this task as Resolved.Sep 22 2015, 11:59 AM
JanZerebecki subscribed.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 22 2015, 12:00 PM
wpmirrordev added a comment.Sep 22 2015, 1:36 PM

I confirm that the above mentioned debian lintian warning is cured.
Thanks.

xSavitar added a comment.EditedSep 22 2015, 1:49 PM

I am happy to hear that. I am glad i fixed the bug that cured the probblem and willing to fix more bugs. :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL