pywikibot proxy support with requests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jayvdb
	Sep 8 2015, 3:36 AM

Description

After the switch from httplib2 to requests, proxy support was 'lost'. It was never really very good in core, as it differed from compat and required messing with httplib2 internals (see https://gerrit.wikimedia.org/r/#/c/137293/)

config2 still includes proxy, but it is now unimplemented.

It is relatively easy to re-add proxy support using requests, and doing it nicely would include a lot of the code.

However requests supports env variables, such as:

$ export HTTP_PROXY="http://10.10.1.10:3128"
$ export HTTPS_PROXY="http://10.10.1.10:1080"

IMO that is 'good enough', and we should decommission config2.proxy.

Details

	Subject	Repo	Branch	Lines +/-
	refactor(config2): remove the unimplemented proxy variable	pywikibot/core	master	+1 -6

Customize query in gerrit

Related Objects

Mentioned In: rPWBC22cc83e21216: refactor(config2): remove the unimplemented proxy variable

Event Timeline

jayvdb created this task.Sep 8 2015, 3:36 AM

jayvdb raised the priority of this task from to Low.

jayvdb updated the task description. (Show Details)

jayvdb added projects: Pywikibot-OAuth, Pywikibot-network.

jayvdb subscribed.

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 8 2015, 3:36 AM

jayvdb moved this task from Backlog to requests on the Pywikibot-network board.Sep 8 2015, 3:37 AM

jayvdb moved this task from Backlog to requests on the Pywikibot-OAuth board.

• Phabricator_maintenance added a project: Pywikibot.Mar 23 2019, 10:17 PM

Change 523529 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] refactor(config2): remove the unimplemented proxy variable

https://gerrit.wikimedia.org/r/523529

gerritbot added a project: Patch-For-Review.Jul 16 2019, 4:44 AM

Xqt closed this task as Resolved.Jul 16 2019, 5:33 AM

Xqt claimed this task.

Xqt reassigned this task from Xqt to Dalba.

Xqt subscribed.

Change 523529 merged by jenkins-bot:
[pywikibot/core@master] refactor(config2): remove the unimplemented proxy variable

https://gerrit.wikimedia.org/r/523529

Dalba mentioned this in rPWBC22cc83e21216: refactor(config2): remove the unimplemented proxy variable.Jul 16 2019, 5:36 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2019, 6:10 AM