Page MenuHomePhabricator

pywikibot proxy support with requests
Closed, ResolvedPublic

Description

After the switch from httplib2 to requests, proxy support was 'lost'. It was never really very good in core, as it differed from compat and required messing with httplib2 internals (see https://gerrit.wikimedia.org/r/#/c/137293/)

config2 still includes proxy, but it is now unimplemented.

It is relatively easy to re-add proxy support using requests, and doing it nicely would include a lot of the code.

However requests supports env variables, such as:

$ export HTTP_PROXY="http://10.10.1.10:3128"
$ export HTTPS_PROXY="http://10.10.1.10:1080"

IMO that is 'good enough', and we should decommission config2.proxy.

Event Timeline

jayvdb raised the priority of this task from to Low.
jayvdb updated the task description. (Show Details)
jayvdb added a subscriber: jayvdb.
jayvdb moved this task from Backlog to requests on the Pywikibot-OAuth board.

Change 523529 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] refactor(config2): remove the unimplemented proxy variable

https://gerrit.wikimedia.org/r/523529

Xqt claimed this task.
Xqt reassigned this task from Xqt to Dalba.
Xqt added a subscriber: Xqt.

Change 523529 merged by jenkins-bot:
[pywikibot/core@master] refactor(config2): remove the unimplemented proxy variable

https://gerrit.wikimedia.org/r/523529