Page MenuHomePhabricator
Create Task
Maniphest T111870

ParsoidBatchAPI: no support for height parameter
Closed, ResolvedPublic
Actions

Description

As noted in a comment on https://gerrit.wikimedia.org/r/#/c/235403/ , ParsoidBatchAPI lacks image width/height handling. It treats its parameters as transform options, not image link frame options, which gives Parsoid no way to do height-based scaling with a single request, unlike the non-batch imageinfo API.

Details

SubjectRepoBranchLines +/-
Fix support for height parameter and mustRendermediawiki/extensions/ParsoidBatchAPImaster+47 -15
Fix support for height parameter and mustRendermediawiki/extensions/ParsoidBatchAPIwmf/1.26wmf22+47 -15
Customize query in gerrit

Related Objects

Event Timeline

tstarling created this task.Sep 8 2015, 10:20 PM
tstarling claimed this task.
tstarling raised the priority of this task from to Needs Triage.
tstarling updated the task description. (Show Details)
tstarling added projects: Parsoid, Parsing-Team--ARCHIVED.
tstarling subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2015, 10:20 PM
tstarling triaged this task as High priority.Sep 8 2015, 10:20 PM
tstarling set Security to None.
gerritbot subscribed.Sep 14 2015, 1:12 AM

Change 238082 had a related patch set uploaded (by Tim Starling):
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238082

gerritbot added a project: Patch-For-Review.Sep 14 2015, 1:12 AM
gerritbot added a comment.Sep 14 2015, 11:00 PM

Change 238082 merged by jenkins-bot:
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238082

tstarling mentioned this in rMEXT1819b70a508b: Updated mediawiki/extensions Project: mediawiki/extensions/ParsoidBatchAPI….Sep 14 2015, 11:01 PM
gerritbot added a comment.Sep 14 2015, 11:21 PM

Change 238356 had a related patch set uploaded (by Tim Starling):
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238356

gerritbot added a comment.Sep 14 2015, 11:21 PM

Change 238356 merged by jenkins-bot:
Fix support for height parameter and mustRender

https://gerrit.wikimedia.org/r/238356

tstarling mentioned this in rMW13214521a74b: Updated mediawiki/core Project: mediawiki/extensions/ParsoidBatchAPI….Sep 14 2015, 11:21 PM
• ssastry closed this task as Resolved.Sep 15 2015, 8:39 PM
• ssastry removed a project: Patch-For-Review.
• ssastry removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits