Page MenuHomePhabricator

Add an external link on Flow is broken
Closed, InvalidPublic

Description

Event Timeline

Trizek-WMF raised the priority of this task from to High.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Halfak renamed this task from Ass an external link on Flow is broken to Add an external link on Flow is broken.Sep 9 2015, 1:52 PM
Halfak set Security to None.
ssastry claimed this task.
ssastry subscribed.

Looking at https://fr.wikipedia.org/w/index.php?title=Sujet:Sojlmrc8frif9b50&action=compare-post-revisions&topic_newRevision=sol89t31vm5jawi6 .. it seems that @Trizek-WMF pasted wikitext in VE mode.

I could easily reproduce the exact same error by pasting

This is a test [https://fr.wikipedia.org/w/index.php?title=Guilbert Express&type=revision&diff=118466065&oldid=117715998 vous avez ajouté quatre références].

in a flow post response and looking at the generated wikitext (using the switch-to-wikitext button at the bottom).

Marking this as invalid accordingly.

I've tried to reproduce what I've done as far as I remember :

  1. type a text on VE
  2. select the word on which I want to create a link on
  3. click on the link button
  4. paste the following URL : https://fr.wikipedia.org/w/index.php?title=Guilbert Express&type=revision&diff=118466065&oldid=117715998
  5. hit enter
  6. see this link has been interpreted as an internal link
  7. edit link
  8. insert, looks good
  9. post

Result

That doesn't seem like a valid URL (because of the space). Even Phabricator is not interpreting it as a single full URL. How did you get that URL exactly?

IIRC, copy/paste from a diff in the Guilbert Express article history. I haven't changed anything on the link.
I've done it again: I copy the link on my browser address bar (which has the underscore) and paste it on the Link dialog box. At this moment, the underscore is missing.

Screenshot - 10092015 - 17:28:15.png (249×443 px, 26 KB)

(May be useful: Firefox 40/Chromium 44 on Xubuntu 14.04)