Maniphest T112407

nojs/mw.echo.special.less styles should only be loaded on Special:Notifications
Closed, ResolvedPublic
Actions

Description

The mw.echo.special.less styles are included in the ext.echo.nojs module that is loaded on every page. We should split it into a separate module (ext.echo.nojs.special) to avoid loading unnecessary CSS and embedded icons on every page.

Spotted by @ori in T112401#1634327.

Details

	Subject	Repo	Branch	Lines +/-
	Only load nojs Special:Notifications styles on the special page	mediawiki/extensions/Echo	wmf/1.26wmf22	+8 -2
	Only load nojs Special:Notifications styles on the special page	mediawiki/extensions/Echo	master	+8 -2

Customize query in gerrit

Related Objects

Mentioned In: rMWd381ac2e031d: Updated mediawiki/core Project: mediawiki/extensions/Echo…
rECHOd7f691316c29: Only load nojs Special:Notifications styles on the special page
rECHO3940f523baf7: Only load nojs Special:Notifications styles on the special page
rMEXTb0ce1967c8fd: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…
Mentioned Here: T112401: Fivefold increase in render-blocking CSS size for logged-in users due to Echo loading OOUI on all page views

Event Timeline

Legoktm created this task.Sep 12 2015, 9:25 PM

Legoktm raised the priority of this task from to High.

Legoktm updated the task description. (Show Details)

Legoktm added projects: Performance Issue, Notifications, good first task.

Legoktm added subscribers: Legoktm, ori.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 12 2015, 9:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Legoktm updated the task description. (Show Details)Sep 12 2015, 9:26 PM

Legoktm set Security to None.

Change 237968 had a related patch set uploaded (by Legoktm):
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/237968

gerritbot added a project: Patch-For-Review.Sep 13 2015, 4:20 AM

Legoktm claimed this task.Sep 13 2015, 4:21 AM

• Mattflaschen-WMF edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.Sep 13 2015, 3:47 PM

• Mattflaschen-WMF moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.

Change 237968 merged by jenkins-bot:
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/237968

Legoktm mentioned this in rMEXTb0ce1967c8fd: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 13 2015, 3:48 PM

Legoktm mentioned this in rECHO3940f523baf7: Only load nojs Special:Notifications styles on the special page.

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 13 2015, 4:00 PM

Legoktm closed this task as Resolved.Sep 13 2015, 11:53 PM

Change 238212 had a related patch set uploaded (by Legoktm):
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/238212

Change 238212 merged by jenkins-bot:
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/238212

Legoktm mentioned this in rECHOd7f691316c29: Only load nojs Special:Notifications styles on the special page.Sep 14 2015, 7:24 PM

Legoktm mentioned this in rMWd381ac2e031d: Updated mediawiki/core Project: mediawiki/extensions/Echo….

ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 14 2015, 8:00 PM

Betalabs http://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector
shows that ext.echo.nojs is present.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 15 2015, 9:08 PM