Page MenuHomePhabricator

nojs/mw.echo.special.less styles should only be loaded on Special:Notifications
Closed, ResolvedPublic

Description

The mw.echo.special.less styles are included in the ext.echo.nojs module that is loaded on every page. We should split it into a separate module (ext.echo.nojs.special) to avoid loading unnecessary CSS and embedded icons on every page.

Spotted by @ori in T112401#1634327.

Event Timeline

Legoktm created this task.Sep 12 2015, 9:25 PM
Legoktm updated the task description. (Show Details)
Legoktm raised the priority of this task from to High.
Legoktm added subscribers: Legoktm, ori.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 12 2015, 9:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm updated the task description. (Show Details)Sep 12 2015, 9:26 PM
Legoktm set Security to None.

Change 237968 had a related patch set uploaded (by Legoktm):
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/237968

Legoktm claimed this task.Sep 13 2015, 4:21 AM

Change 237968 merged by jenkins-bot:
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/237968

Legoktm closed this task as Resolved.Sep 13 2015, 11:53 PM

Change 238212 had a related patch set uploaded (by Legoktm):
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/238212

Change 238212 merged by jenkins-bot:
Only load nojs Special:Notifications styles on the special page

https://gerrit.wikimedia.org/r/238212