Page MenuHomePhabricator
Create Task
Maniphest T112600

Max-width `close` label visible
Closed, ResolvedPublic
Actions

Description

at a screen resolution of 1893px I am seeing the label for the close icon when I click edit.
Let's not do that.

Screen Shot 2015-09-14 at 3.51.10 PM.png (471×1 px, 127 KB)

http://localhost:8888/w/index.php/Selenium_no_languages_test_page#/editor/0

Details

SubjectRepoBranchLines +/-
Hide the back button labelmediawiki/extensions/MobileFrontendmaster+0 -6
Don't show close icon when max-width applyingmediawiki/extensions/MobileFrontendmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 14 2015, 10:52 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-56-Four Lions.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 10:52 PM
Jdlrobson updated the task description. (Show Details)Sep 14 2015, 11:53 PM
Jdlrobson set Security to None.
gerritbot subscribed.Sep 14 2015, 11:55 PM

Change 238362 had a related patch set uploaded (by Jdlrobson):
Don't show close icon when max-width applying

https://gerrit.wikimedia.org/r/238362

gerritbot added a project: Patch-For-Review.Sep 14 2015, 11:55 PM
Jdlrobson claimed this task.Sep 14 2015, 11:55 PM
Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-56-Four Lions board.
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 15 2015, 12:24 AM
gerritbot added a comment.Sep 15 2015, 12:36 AM

Change 238362 merged by jenkins-bot:
Don't show close icon when max-width applying

https://gerrit.wikimedia.org/r/238362

Diffusion mentioned this in rMEXT0a2a750f79e1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 15 2015, 12:36 AM
• Konfused-Kitten mentioned this in rEMFRdb89533b327d: Don't show close icon when max-width applying.Sep 15 2015, 12:36 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 15 2015, 1:00 AM
Jdlrobson closed this task as Resolved.Sep 15 2015, 9:03 PM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson reopened this task as Open.Sep 16 2015, 8:41 PM
Jdlrobson moved this task from Done to To Do on the Reading-Web-Sprint-56-Four Lions board.

The fix had to be reverted (it broken the switcher in the editor which was far more serious) so moving back.

Jdlrobson removed Jdlrobson as the assignee of this task.Sep 16 2015, 9:22 PM
Jdlrobson lowered the priority of this task from High to Medium.
Jdlrobson removed projects: WMF-deploy-2015-09-15_(1.26wmf23), Patch-For-Review.
• bmansurov claimed this task.Sep 17 2015, 10:31 AM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-56-Four Lions board.
gerritbot added a comment.Sep 17 2015, 11:59 AM

Change 239081 had a related patch set uploaded (by Bmansurov):
Hide the back button label

https://gerrit.wikimedia.org/r/239081

gerritbot added a project: Patch-For-Review.Sep 17 2015, 11:59 AM
• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 12:00 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 3:41 PM
gerritbot added a comment.Sep 17 2015, 3:49 PM

Change 239081 merged by jenkins-bot:
Hide the back button label

https://gerrit.wikimedia.org/r/239081

Diffusion mentioned this in rMEXT910db8f6e7b0: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 17 2015, 3:49 PM
• bmansurov mentioned this in rEMFR9bd33f2eaedc: Hide the back button label.Sep 17 2015, 3:49 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 17 2015, 4:00 PM
phuedx closed this task as Resolved.Sep 21 2015, 9:47 AM
phuedx subscribed.

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.Sep 21 2015, 9:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits