Page MenuHomePhabricator

Max-width `close` label visible
Closed, ResolvedPublic

Description

at a screen resolution of 1893px I am seeing the label for the close icon when I click edit.
Let's not do that.

Screen Shot 2015-09-14 at 3.51.10 PM.png (471×1 px, 127 KB)

http://localhost:8888/w/index.php/Selenium_no_languages_test_page#/editor/0

Event Timeline

Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson added a subscriber: Jdlrobson.

Change 238362 had a related patch set uploaded (by Jdlrobson):
Don't show close icon when max-width applying

https://gerrit.wikimedia.org/r/238362

Change 238362 merged by jenkins-bot:
Don't show close icon when max-width applying

https://gerrit.wikimedia.org/r/238362

Jdlrobson moved this task from Done to To Do on the Reading-Web-Sprint-56-Four Lions board.

The fix had to be reverted (it broken the switcher in the editor which was far more serious) so moving back.

Jdlrobson lowered the priority of this task from High to Medium.

Change 239081 had a related patch set uploaded (by Bmansurov):
Hide the back button label

https://gerrit.wikimedia.org/r/239081

Change 239081 merged by jenkins-bot:
Hide the back button label

https://gerrit.wikimedia.org/r/239081

phuedx added a subscriber: phuedx.

Verified on BC.