Page MenuHomePhabricator
Create Task
Maniphest T112651

Fix easy problems reported by RuboCop in operations/puppet
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
RuboCop: fixed Style/ColonMethodCall offenceoperations/puppetproduction+2 -9
RuboCop: fixed Style/CommandLiteral offenseoperations/puppetproduction+3 -12
RuboCop: Fixed Style/DefWithParentheses offenceoperations/puppetproduction+1 -7
RuboCop: fixed Style/EmptyLiteral offenseoperations/puppetproduction+2 -9
RuboCop: fixed Style/IfUnlessModifier offenseoperations/puppetproduction+22 -72
RuboCop: fixed Style/LeadingCommentSpace offenseoperations/puppetproduction+6 -16
RuboCop: fixed Style/MethodCallParentheses offenseoperations/puppetproduction+15 -30
RuboCop: fixed Style/MultilineIfThen offenseoperations/puppetproduction+1 -7
RuboCop: fixed Style/NegatedIf offenseoperations/puppetproduction+20 -25
RuboCop: fixed Style/Not offenseoperations/puppetproduction+6 -17
RuboCop: fixed Style/NumericLiterals offenseoperations/puppetproduction+3 -8
RuboCop: fixed Style/ParallelAssignment offenseoperations/puppetproduction+2 -7
RuboCop: fixed Style/CaseIndentation offenseoperations/puppetproduction+15 -18
RuboCop: Fixed Style/BlockDelimiters offenseoperations/puppetproduction+116 -122
RuboCop: fixed Lint/UnusedMethodArgument offenseoperations/puppetproduction+2 -10
RuboCop: fixed Style/AndOr offenseoperations/puppetproduction+15 -30
RuboCop: fixed Style/AlignParameters parametersoperations/puppetproduction+3 -10
RuboCop: Fixed Lint/UnusedBlockArgument offenseoperations/puppetproduction+3 -11
RuboCop: fixed Style/DeprecatedHashMethods offenseoperations/puppetproduction+7 -16
RuboCop: fixed Style/StringLiterals offenseoperations/puppetproduction+159 -174
RuboCop: fixed Style/Tab offenseoperations/puppetproduction+49 -57
RuboCop: fixed Style/TrailingBlankLines offenseoperations/puppetproduction+0 -8
Updated RuboCop to the newest released versionoperations/puppetproduction+23 -17
rubocop: Ignoring Style/WordArray offenseoperations/puppetproduction+3 -6
rubocop: Ignore Style/TrailingComma offenseoperations/puppetproduction+3 -6
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Sep 15 2015, 1:37 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a project: Puppet.
zeljkofilipin subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2015, 1:37 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 15 2015, 1:40 PM
gerritbot subscribed.Sep 16 2015, 4:14 PM

Change 238778 had a related patch set uploaded (by Zfilipin):
rubocop: Fixed Style/WordArray offense

https://gerrit.wikimedia.org/r/238778

gerritbot added a project: Patch-For-Review.Sep 16 2015, 4:14 PM
gerritbot added a comment.Sep 16 2015, 4:19 PM

Change 238779 had a related patch set uploaded (by Zfilipin):
rubocop: Fixed Style/TrailingComma offense

https://gerrit.wikimedia.org/r/238779

zeljkofilipin set Security to None.Sep 16 2015, 4:25 PM
zeljkofilipin added subscribers: akosiaris, dduvall, hashar and 2 others.
gerritbot added a comment.Oct 15 2015, 4:23 PM

Change 238779 abandoned by Zfilipin:
rubocop: Ignore Style/TrailingComma offense

https://gerrit.wikimedia.org/r/238779

zeljkofilipin added a project: Ruby.Nov 9 2015, 2:46 PM
hashar unsubscribed.Nov 9 2015, 2:47 PM
zeljkofilipin changed the task status from Open to Stalled.Nov 9 2015, 2:47 PM
gerritbot added a comment.Nov 9 2015, 7:55 PM

Change 238778 merged by Alexandros Kosiaris:
rubocop: Ignoring Style/WordArray offense

https://gerrit.wikimedia.org/r/238778

zeljkofilipin changed the task status from Stalled to Open.Nov 12 2015, 11:29 AM
zeljkofilipin removed a project: Patch-For-Review.
gerritbot added a comment.Nov 12 2015, 5:44 PM

Change 252721 had a related patch set uploaded (by Zfilipin):
Updated RuboCop to the newest released version

https://gerrit.wikimedia.org/r/252721

gerritbot added a project: Patch-For-Review.Nov 12 2015, 5:44 PM
gerritbot added a comment.Nov 13 2015, 9:06 AM

Change 252721 merged by Alexandros Kosiaris:
Updated RuboCop to the newest released version

https://gerrit.wikimedia.org/r/252721

gerritbot added a comment.Nov 16 2015, 4:58 PM

Change 253349 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/253349

gerritbot added a comment.Nov 16 2015, 4:58 PM

Change 253350 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/Tab offense

https://gerrit.wikimedia.org/r/253350

gerritbot added a comment.Nov 16 2015, 4:58 PM

Change 253351 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/StringLiterals offense

https://gerrit.wikimedia.org/r/253351

gerritbot added a comment.Nov 17 2015, 3:39 PM

Change 253349 merged by Alexandros Kosiaris:
RuboCop: fixed Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/253349

gerritbot added a comment.Nov 17 2015, 3:41 PM

Change 253350 merged by Alexandros Kosiaris:
RuboCop: fixed Style/Tab offense

https://gerrit.wikimedia.org/r/253350

gerritbot added a comment.Nov 20 2015, 4:43 PM

Change 253351 abandoned by Zfilipin:
RuboCop: fixed Style/StringLiterals offense

https://gerrit.wikimedia.org/r/253351

gerritbot added a comment.Nov 20 2015, 5:11 PM

Change 254428 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/DeprecatedHashMethods offense

https://gerrit.wikimedia.org/r/254428

gerritbot added a comment.Nov 23 2015, 10:42 AM

Change 254428 merged by Alexandros Kosiaris:
RuboCop: fixed Style/DeprecatedHashMethods offense

https://gerrit.wikimedia.org/r/254428

gerritbot added a comment.Nov 23 2015, 12:00 PM

Change 254833 had a related patch set uploaded (by Zfilipin):
RuboCop: Fixed Lint/UnusedBlockArgument offense

https://gerrit.wikimedia.org/r/254833

gerritbot added a comment.Nov 23 2015, 12:09 PM

Change 254838 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Lint/UnusedMethodArgument offense

https://gerrit.wikimedia.org/r/254838

gerritbot added a comment.Nov 23 2015, 12:13 PM

Change 254833 merged by Alexandros Kosiaris:
RuboCop: Fixed Lint/UnusedBlockArgument offense

https://gerrit.wikimedia.org/r/254833

gerritbot added a comment.Nov 23 2015, 12:14 PM

Change 254839 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/AlignParameters parameters

https://gerrit.wikimedia.org/r/254839

gerritbot added a comment.Nov 23 2015, 12:18 PM

Change 254841 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/AndOr offense

https://gerrit.wikimedia.org/r/254841

gerritbot added a comment.Nov 23 2015, 12:35 PM

Change 254839 merged by Alexandros Kosiaris:
RuboCop: fixed Style/AlignParameters parameters

https://gerrit.wikimedia.org/r/254839

gerritbot added a comment.Nov 23 2015, 2:20 PM

Change 254855 had a related patch set uploaded (by Zfilipin):
RuboCop: Fixed Style/BlockDelimiters offense

https://gerrit.wikimedia.org/r/254855

gerritbot added a comment.Nov 25 2015, 1:44 PM

Change 254841 merged by Alexandros Kosiaris:
RuboCop: fixed Style/AndOr offense

https://gerrit.wikimedia.org/r/254841

gerritbot added a comment.Dec 17 2015, 2:26 PM

Change 254838 abandoned by Zfilipin:
RuboCop: fixed Lint/UnusedMethodArgument offense

https://gerrit.wikimedia.org/r/254838

gerritbot added a comment.Dec 17 2015, 2:26 PM

Change 254855 abandoned by Zfilipin:
RuboCop: Fixed Style/BlockDelimiters offense

https://gerrit.wikimedia.org/r/254855

gerritbot added a comment.Dec 17 2015, 2:53 PM

Change 259699 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/CaseIndentation offense

https://gerrit.wikimedia.org/r/259699

gerritbot added a comment.Dec 17 2015, 3:00 PM

Change 259702 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/ColonMethodCall offence

https://gerrit.wikimedia.org/r/259702

gerritbot added a comment.Dec 17 2015, 3:04 PM

Change 259706 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/CommandLiteral offense

https://gerrit.wikimedia.org/r/259706

gerritbot added a comment.Dec 17 2015, 3:07 PM

Change 259708 had a related patch set uploaded (by Zfilipin):
RuboCop: Fixed Style/DefWithParentheses offence

https://gerrit.wikimedia.org/r/259708

gerritbot added a comment.Dec 17 2015, 3:10 PM

Change 259710 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/EmptyLiteral offense

https://gerrit.wikimedia.org/r/259710

gerritbot added a comment.Dec 17 2015, 3:18 PM

Change 259716 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/IfUnlessModifier offense

https://gerrit.wikimedia.org/r/259716

gerritbot added a comment.Dec 17 2015, 3:24 PM

Change 259717 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/LeadingCommentSpace offense

https://gerrit.wikimedia.org/r/259717

gerritbot added a comment.Dec 17 2015, 3:27 PM

Change 259718 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/MethodCallParentheses offense

https://gerrit.wikimedia.org/r/259718

gerritbot added a comment.Dec 17 2015, 3:29 PM

Change 259719 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/MultilineIfThen offense

https://gerrit.wikimedia.org/r/259719

gerritbot added a comment.Dec 17 2015, 3:34 PM

Change 259722 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/NegatedIf offense

https://gerrit.wikimedia.org/r/259722

gerritbot added a comment.Dec 17 2015, 3:36 PM

Change 259724 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/Not offense

https://gerrit.wikimedia.org/r/259724

gerritbot added a comment.Dec 17 2015, 3:39 PM

Change 259725 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/NumericLiterals offense

https://gerrit.wikimedia.org/r/259725

gerritbot added a comment.Dec 17 2015, 3:40 PM

Change 259726 had a related patch set uploaded (by Zfilipin):
RuboCop: fixed Style/ParallelAssignment offense

https://gerrit.wikimedia.org/r/259726

gerritbot added a comment.Jan 7 2016, 5:16 PM

Change 259699 merged by Alexandros Kosiaris:
RuboCop: fixed Style/CaseIndentation offense

https://gerrit.wikimedia.org/r/259699

zeljkofilipin removed zeljkofilipin as the assignee of this task.Feb 15 2016, 1:43 PM
zeljkofilipin removed a project: Patch-For-Review.
gerritbot added a comment.Feb 15 2016, 1:43 PM

Change 259726 abandoned by Zfilipin:
RuboCop: fixed Style/ParallelAssignment offense

https://gerrit.wikimedia.org/r/259726

gerritbot added a comment.Feb 15 2016, 1:43 PM

Change 259725 abandoned by Zfilipin:
RuboCop: fixed Style/NumericLiterals offense

https://gerrit.wikimedia.org/r/259725

gerritbot added a comment.Feb 15 2016, 1:43 PM

Change 259724 abandoned by Zfilipin:
RuboCop: fixed Style/Not offense

https://gerrit.wikimedia.org/r/259724

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259722 abandoned by Zfilipin:
RuboCop: fixed Style/NegatedIf offense

https://gerrit.wikimedia.org/r/259722

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259719 abandoned by Zfilipin:
RuboCop: fixed Style/MultilineIfThen offense

https://gerrit.wikimedia.org/r/259719

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259718 abandoned by Zfilipin:
RuboCop: fixed Style/MethodCallParentheses offense

https://gerrit.wikimedia.org/r/259718

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259717 abandoned by Zfilipin:
RuboCop: fixed Style/LeadingCommentSpace offense

https://gerrit.wikimedia.org/r/259717

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259716 abandoned by Zfilipin:
RuboCop: fixed Style/IfUnlessModifier offense

https://gerrit.wikimedia.org/r/259716

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259710 abandoned by Zfilipin:
RuboCop: fixed Style/EmptyLiteral offense

https://gerrit.wikimedia.org/r/259710

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259708 abandoned by Zfilipin:
RuboCop: Fixed Style/DefWithParentheses offence

https://gerrit.wikimedia.org/r/259708

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259706 abandoned by Zfilipin:
RuboCop: fixed Style/CommandLiteral offense

https://gerrit.wikimedia.org/r/259706

gerritbot added a comment.Feb 15 2016, 1:44 PM

Change 259702 abandoned by Zfilipin:
RuboCop: fixed Style/ColonMethodCall offence

https://gerrit.wikimedia.org/r/259702

hashar closed this task as Resolved.Feb 16 2016, 2:39 PM
hashar assigned this task to zeljkofilipin.
hashar subscribed.

Bulk of rubocop issues have been fixed. A lot of changes have been abandoned but rubocop is running nonetheless. When there is interest in being rubocop free, people can just propose patch to fix the rest of the TODO entries.

Meanwhile the bulk of easy/non controversial links are applied and running. Hence this task is complete.

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:47 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJun 7 2017, 6:47 PM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits