Page MenuHomePhabricator
Create Task
Maniphest T112988

Close icon in notification icon displaced in stable on desktop screens
Closed, ResolvedPublic
Actions

Description

Embarrassingly the close icon is misplaced on tablets:

Screen Shot 2015-09-17 at 3.08.00 PM.png (917×1 px, 132 KB)

Let's fix this for next week. I doubt we'll make the SWAT window this afternoon.

Details

SubjectRepoBranchLines +/-
Do not apply max-width to notifications overlaymediawiki/extensions/MobileFrontendmaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 17 2015, 10:11 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Reading-Web-Sprint-56-Four Lions.
Jdlrobson moved this task to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2015, 10:11 PM
Volker_E subscribed.Sep 17 2015, 10:32 PM
phuedx subscribed.Sep 18 2015, 9:43 AM

Interestingly, I see the following on enwiki in stable:

Screen Shot 2015-09-18 at 10.41.03.png (69×230 px, 9 KB)

and nothing out of the ordinary in beta.

Jdlrobson added a comment.Sep 18 2015, 3:39 PM

Yup I now see this too.
Seems like some caching issue.
The issue is that hacky -1em we use all over the place:

.overlay-header .cancel {
    /* left: -1em; */
Jdlrobson claimed this task.Sep 18 2015, 11:52 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-56-Four Lions board.
gerritbot subscribed.Sep 19 2015, 12:00 AM

Change 239519 had a related patch set uploaded (by Jdlrobson):
Do not apply max-width to notifications overlay

https://gerrit.wikimedia.org/r/239519

gerritbot added a project: Patch-For-Review.Sep 19 2015, 12:00 AM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 19 2015, 12:00 AM
phuedx added a comment.Sep 21 2015, 9:46 AM

@Jdlrobson: I don't see this locally or on BC any more and so I can't verify 239519. I'm tempted to move this to Ready for Signoff with a reminder to check enwiki on Tuesday.

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-56-Four Lions board.Sep 21 2015, 5:21 PM
Jdlrobson added a comment.Sep 21 2015, 5:31 PM

So it seems like I was mistaken. This kicks in for desktop. Try 1882px for example. (You can zoom out on your browser to mimic this)

Jdlrobson renamed this task from Close icon in notification icon displaced in stable to Close icon in notification icon displaced in stable on desktop screens .Sep 21 2015, 5:32 PM
Jdlrobson set Security to None.
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-56-Four Lions board.
gerritbot added a comment.Sep 22 2015, 10:08 AM

Change 239519 merged by jenkins-bot:
Do not apply max-width to notifications overlay

https://gerrit.wikimedia.org/r/239519

Diffusion mentioned this in rMEXT49a0de8b454c: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 22 2015, 10:08 AM
• Konfused-Kitten mentioned this in rEMFR52d243b6e9f5: Do not apply max-width to notifications overlay.Sep 22 2015, 10:09 AM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 22 2015, 10:13 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 22 2015, 11:00 AM
phuedx closed this task as Resolved.Sep 23 2015, 8:14 AM

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.Sep 23 2015, 8:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits