Embarrassingly the close icon is misplaced on tablets:
Let's fix this for next week. I doubt we'll make the SWAT window this afternoon.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Do not apply max-width to notifications overlay | mediawiki/extensions/MobileFrontend | master | +9 -2 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Interestingly, I see the following on enwiki in stable:
and nothing out of the ordinary in beta.
Comment Actions
Yup I now see this too.
Seems like some caching issue.
The issue is that hacky -1em we use all over the place:
.overlay-header .cancel {
/* left: -1em; */Comment Actions
Change 239519 had a related patch set uploaded (by Jdlrobson):
Do not apply max-width to notifications overlay
Comment Actions
@Jdlrobson: I don't see this locally or on BC any more and so I can't verify 239519. I'm tempted to move this to Ready for Signoff with a reminder to check enwiki on Tuesday.
Comment Actions
So it seems like I was mistaken. This kicks in for desktop. Try 1882px for example. (You can zoom out on your browser to mimic this)