Maniphest T113667

Watchlist shouldn't re-render
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Sep 24 2015, 9:36 PM

Tags

Referenced Files

	F2645380: Screen Shot 2015-09-29 at 3.44.11 PM.png
	Sep 29 2015, 10:44 PM

	F2645370: Screen Shot 2015-09-29 at 3.38.04 PM.png
	Sep 29 2015, 10:38 PM

Subscribers

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:EditWatchlist on a screen resolution of 768px or greater
and you'll notice a view-border-box class gets unnecessarily added to the element with classes "watchlist content-unstyled page-list thumbs page-summary-list view-border-box"

This shouldn't happen and causes a visible styling regression.

Expected:

Screen Shot 2015-09-29 at 3.44.11 PM.png (353×911 px, 31 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Remove the unneeded view-border-box class from the watchlist	mediawiki/extensions/MobileFrontend	master	+1 -0

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 24 2015, 9:36 PM

Jdlrobson raised the priority of this task from to High.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: MobileFrontend, good first task.

Jdlrobson moved this task to Backlog on the MobileFrontend board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 9:36 PM

Will work on the bug soon.

Screen Shot 2015-09-29 at 3.38.04 PM.png (291×932 px, 32 KB)

Jdlrobson updated the task description. (Show Details)Sep 29 2015, 10:44 PM

Jdlrobson set Security to None.

Jdlrobson added a project: Google-Code-In-2015.Oct 28 2015, 10:37 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Nov 4 2015, 5:01 PM

Jdlrobson added a project: Reading Web Sprint 61 - Cold Hard Cache.Dec 2 2015, 11:44 PM

• bmansurov claimed this task.Dec 3 2015, 1:29 PM

• bmansurov moved this task from Needs Analysis to Code Review on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 3 2015, 1:32 PM

@bmansurov: Where's the change associated with this task?

Change 256677 had a related patch set uploaded (by Bmansurov):
Remove the unneeded view-border-box class from the watchlist

https://gerrit.wikimedia.org/r/256677

gerritbot added a project: Patch-For-Review.Dec 3 2015, 1:54 PM

Didn't see ! [remote rejected] until you mentioned the patch, @phuedx. Thanks

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 3 2015, 6:20 PM

Change 256677 merged by jenkins-bot:
Remove the unneeded view-border-box class from the watchlist

https://gerrit.wikimedia.org/r/256677

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 3 2015, 7:00 PM

Jdlrobson closed this task as Resolved.Dec 3 2015, 10:13 PM

Jdlrobson moved this task from Ready for Signoff to Done on the Reading Web Sprint 61 - Cold Hard Cache board.Dec 8 2015, 12:23 AM

Aklapper removed a project: Google-Code-In-2015.Dec 14 2015, 9:22 PM