Page MenuHomePhabricator

[Research] Investigate regression Save Timing as of 2015-09-10
Closed, ResolvedPublic

Description

Around 10 September our Save Timing went up by about 100-150ms and it hasn't come back down much since.

https://grafana.wikimedia.org/#/dashboard/db/save-timing

Screen Shot 2015-09-30 at 21.45.11.png (472×1 px, 172 KB)

The graph shows it coming down gradually over the course of several weeks (as a result of @aaron's work), but then went back up.

Screen Shot 2015-10-08 at 12.45.45.png (750×2 px, 92 KB)

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: Krinkle, ori, aaron.
Krinkle triaged this task as Medium priority.Oct 5 2015, 6:20 PM
Krinkle set Security to None.
Krinkle raised the priority of this task from Medium to High.Oct 20 2015, 1:09 AM
aaron claimed this task.

The hook error handling change may have fixed the cause, or at least negated the performance loss.

Because xenon does not go back this far, it would be pretty hard to be sure what code caused this. In any case, more edit save performance tweaks will keep happening.