Page MenuHomePhabricator

Auto edit conflict on VE is not warned
Closed, InvalidPublic

Description

User case:

  1. open the same page on two tabs
  2. edit tab 1
  3. edit tab 2
  4. change something on tab 1, save
  5. change the same element with a different content on tab 2, save

With wikitext, you have an edit conflict warning, not with VE.
Feedback - Screencast

Event Timeline

Trizek-WMF raised the priority of this task from to Needs Triage.
Trizek-WMF updated the task description. (Show Details)
Trizek-WMF added a project: VisualEditor.
Trizek-WMF added subscribers: Trizek-WMF, Vatadoshu.
Jdforrester-WMF set Security to None.
Krenair closed this task as Invalid.EditedNov 10 2015, 1:31 AM
Krenair claimed this task.

I guess it's not obvious what's really going on here. VisualEditor doesn't detect edit conflicts itself - we just send off data to the MediaWiki edit API.
MediaWiki's edit conflict handling will suppress the edit conflict error if the second save to be made is full-page (not just a section edit) and the saving user is the last editor of that page - i.e., self-conflicts are suppressed for full-page edits.
All VE saves are full-page (currently, anyway), so you need to be comparing it to full page wikitext edits for any comparisons about edit conflict behaviour to make any sense.

Oh, and to make things slightly more confusing - the "saving user is the last editor of that page" check will never suppress full-page self-conflicts for anonymous users. It only works for logged in users.

And new sections never trigger edit conflicts.

There are probably more cases...