Suppress delete button (icon) if search history is empty
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	Oct 23 2015, 11:12 PM

Description

Suppress delete button (icon) if the search history is empty.

Current situation: the delete button is always shown, is inactive when the search history is empty.

Related:
In T116431 it was suggested to suppress the delete button on empty (article) history.

	Subject	Repo	Branch	Lines +/-
	Suppress delete button icon on empty search history page	apps/android/wikipedia	master	+5 -0

Mentioned Here: T115670: [Regression 5.0.0 (407) ] After deleting all recent searches, 'Recent searches' still displayed
T116431: Suppress delete button (icon) if history is empty

Wikinaut raised the priority of this task from to Needs Triage.

Wikinaut updated the task description. (Show Details)

Wikinaut subscribed.

Change 248565 had a related patch set uploaded (by Wikinaut):
Suppress delete button on empty search history page

Change 248565 merged by jenkins-bot:
Suppress delete button icon on empty search history page

Dbrant subscribed.

Checked with 2.0.133-alpha-2015-10-28 on Nexus 5

IMPORTANT: the issue is still present in 2.1.133-r-2015-10-26

Dbrant closed this task as Resolved.Nov 9 2015, 3:38 PM