Page MenuHomePhabricator
Create Task
Maniphest T116732

ContentTranslation zend tests fail because of Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit
Closed, ResolvedPublic
Actions

Description

Tests for all ContentTranslation commits fail the the Zend job, for example at https://gerrit.wikimedia.org/r/#/c/248864/

Errors like the following appear in the Jenkins output:

Looking at the last failure of mwext-testextension-zend on https://gerrit.wikimedia.org/r/#/c/248864/ the actual failures are:

There were 3 failures:
1) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #3 (
       array(array(array(1, 60))), array(), array(array('foo', 'foo', true), array('foo', 'Foo', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
2) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #4 (
       array(array(array(1, 60)), array(array(10, 60))), array(), array(array('foo', 'foo', true), array('bar', 'bar', false), array('foo', 'Foo', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
3) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #5 (
       array(array(array(10, 60)), array(array(1, 60))), array(), array(array('foo', 'foo', true), array('foo', 'Foo', true), array('bar', 'bar', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137

Unbreak Now because it blocks ContentTranslation development.

Event Timeline

Amire80 created this task.Oct 27 2015, 9:59 AM
Amire80 raised the priority of this task from to Unbreak Now!.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, ContentTranslation-Release7, LE-CX7-Sprint 2, Unplanned-Sprint-Work, Continuous-Integration-Config, Wikidata.
Amire80 added subscribers: Amire80, aude, hashar, JanZerebecki.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2015, 9:59 AM
Amire80 moved this task from Backlog to In Progress on the LE-CX7-Sprint 2 board.Oct 27 2015, 10:00 AM
Amire80 moved this task from Backlog to Infrastructure WMF requirements on the ContentTranslation-Release7 board.
Amire80 moved this task from Needs Triage to CX7 on the ContentTranslation board.
Amire80 added a project: Essential-Work.
Amire80 set Security to None.
hashar added a comment.Oct 27 2015, 11:49 AM

Wikibase tests that depends on Scribunto are skipped whenever Scribunto is missing. That is the message being shown (Scribunto is not available).

Looking at the last failure of mwext-testextension-zend on https://gerrit.wikimedia.org/r/#/c/248864/ the actual failures are:

There were 3 failures:
1) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #3 (
       array(array(array(1, 60))), array(), array(array('foo', 'foo', true), array('foo', 'Foo', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
2) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #4 (
       array(array(array(1, 60)), array(array(10, 60))), array(), array(array('foo', 'foo', true), array('bar', 'bar', false), array('foo', 'Foo', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137
3) Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit with data set #5 (
       array(array(array(10, 60)), array(array(1, 60))), array(), array(array('foo', 'foo', true), array('foo', 'Foo', true), array('bar', 'bar', false))
   )
array (
)
Failed asserting that true matches expected false.

mwext-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/repo/tests/phpunit/includes/EditEntityTest.php:673
mwext-testextension-zend/src/tests/phpunit/MediaWikiTestCase.php:137

I will repurpose the task. You probably want to reach out to Wikidata people for further analysis.

hashar renamed this task from ContentTranslation zend tests fail because of a missing Wikidata/Scribunto dependency to ContentTranslation zend tests fail because of Wikibase\Test\EditEntityTest::testAttemptSaveRateLimit.Oct 27 2015, 11:49 AM
hashar updated the task description. (Show Details)
hashar added a comment.Oct 27 2015, 11:52 AM

Per IRC might fixed by https://gerrit.wikimedia.org/r/#/c/249083/

hashar added a comment.EditedOct 27 2015, 11:56 AM

Did not fix it, the job is still falling https://integration.wikimedia.org/ci/job/mwext-testextension-zend/13351/ though this time with:

UsageException: The wiki is currently in read-only mode

Amire80 added a comment.Oct 27 2015, 5:13 PM

Appears to be fixed now.

Amire80 moved this task from In Progress to Done on the LE-CX7-Sprint 2 board.Oct 27 2015, 5:41 PM
JanZerebecki closed this task as Resolved.Oct 29 2015, 11:02 AM
JanZerebecki claimed this task.

I think this was caused by a core change that broke Wikibase and was fixed by a revert.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL