Page MenuHomePhabricator
Create Task
Maniphest T117086

Search regression - redirect text missing from search results
Closed, ResolvedPublic
Actions

Assigned To
• Fjalapeno
Authored By
Mhurd
Oct 29 2015, 7:40 PM
Tags
Referenced Files
F2912159: IMG_0052.PNG
Nov 3 2015, 8:30 PM
F2908130: IMG_0047.PNG
Nov 2 2015, 6:23 PM
F2908132: IMG_0046.PNG
Nov 2 2015, 6:23 PM
F2893231: Screen_Shot_2015-10-28_at_5.13.53_PM.png
Oct 29 2015, 7:42 PM
F2893230: Screen Shot 2015-10-29 at 12.04.20 PM.png
Oct 29 2015, 7:42 PM
Subscribers
Aklapper
Etonkovidova
• JMinor
Mhurd

Description

Previous builds followed the spec:

Search Item View

Scenario Redirects

Given that I have entered a search $query
When that $query result includes a page with a redirect
Then I should see a list item with the redirect title
And subhead text with “Redirected from $query”

Pre-regression:

Screen_Shot_2015-10-28_at_5.13.53_PM.png (1×974 px, 371 KB)

Alpha Build 454 does not:
Regression:

Screen Shot 2015-10-29 at 12.04.20 PM.png (1×675 px, 185 KB)

Related Objects

Event Timeline

Mhurd created this task.Oct 29 2015, 7:40 PM
Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd added projects: Wikipedia-iOS-App-Development, iOS-app-v5-beta.
Mhurd moved this task to Tasks from Product Backlog on the Wikipedia-iOS-App-Development board.
Mhurd subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2015, 7:40 PM
Mhurd updated the task description. (Show Details)Oct 29 2015, 7:42 PM
Mhurd set Security to None.
• JMinor triaged this task as Medium priority.Oct 29 2015, 10:16 PM
• JMinor updated the task description. (Show Details)
• JMinor updated the task description. (Show Details)
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.Oct 30 2015, 3:10 PM
• Fjalapeno moved this task from Doing to Tasks from Product Backlog on the Wikipedia-iOS-App-Development board.
• Fjalapeno claimed this task.Oct 30 2015, 5:19 PM
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.
• Fjalapeno moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.
Diffusion mentioned this in rAPIOS9b9b8579a28c: Merge pull request #218 from wikimedia/feature/T117086/search-redirect.Oct 30 2015, 5:49 PM
Mhurd moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Oct 30 2015, 5:53 PM
Etonkovidova subscribed.Nov 2 2015, 6:23 PM

Checked with 5.0.0.454 iPhone 5 iOS 9.02 - there is no Redirect info in Search results, or on articles themselves:

  • type "planet proserpina" to make sure that Search result return 'Eris (dwarf planet)' which is a redirect article.

IMG_0046.PNG (1×640 px, 106 KB)

IMG_0047.PNG (1×640 px, 257 KB)

Note: the same behavior in Android.

Etonkovidova added a comment.Nov 3 2015, 8:30 PM

Checked with 5.0.0.465 on iPhone 5 iOS 9.02 - 'Redirected from...' is displayed in Search results list:

IMG_0052.PNG (1×640 px, 136 KB)

Note: the article to which 'Redirected from ...' redirects does not display this fact.

Etonkovidova moved this task from Needs QA to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Nov 3 2015, 8:30 PM
• JMinor closed this task as Resolved.Nov 18 2015, 8:35 PM
• JMinor subscribed.
Diffusion mentioned this in rAPIOSf3bc514cb8fa: Merge pull request #218 from wikimedia/feature/T117086/search-redirect.Dec 28 2015, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL