sort() call in FeatureIndex caused non-deterministic behavior
Closed, ResolvedPublic

Description

sort doesn't have reliable behavior when the types vary ("Warning: Be careful when sorting arrays with mixed types values because sort() can produce unpredictable results.")

This caused the insert and access paths for links to use different keys (maybe affected other places as well, so updating the overall key to be sure).

This meant the core links tables wouldn't always be properly updated, meaning WhatLinksHere and LinkSearch could be wrong.

We'll run FlowFixLinks afterwards to fix the core tables.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2015, 12:03 AM

Change 249934 had a related patch set uploaded (by Mattflaschen):
Fix non-deterministic behavior in FeatureIndex

https://gerrit.wikimedia.org/r/249934

Change 249935 had a related patch set uploaded (by Mattflaschen):
Remove Flow cache version override

https://gerrit.wikimedia.org/r/249935

Mattflaschen-WMF set Security to None.

Change 249934 merged by jenkins-bot:
Fix non-deterministic behavior in FeatureIndex

https://gerrit.wikimedia.org/r/249934

Change 249940 had a related patch set uploaded (by Catrope):
Fix non-deterministic behavior in FeatureIndex

https://gerrit.wikimedia.org/r/249940

Change 249935 merged by jenkins-bot:
Remove Flow cache version override

https://gerrit.wikimedia.org/r/249935

Change 249940 merged by jenkins-bot:
Fix non-deterministic behavior in FeatureIndex

https://gerrit.wikimedia.org/r/249940

Was SWATted out today, and I ran FlowFixLinks on all Flow wikis.

Catrope closed this task as Resolved.Nov 22 2015, 10:36 PM
Catrope added a subscriber: Catrope.