Page MenuHomePhabricator
Create Task
Maniphest T117578

Regression: Collapse chevron indicators on mobile web initialized incorrectly
Closed, ResolvedPublic
Actions

Assigned To
• jhobs
Authored By
TheDJ
Nov 3 2015, 6:37 PM
Tags
Referenced Files
F2912023: Screen Shot 2015-11-03 at 19.32.53.png
Nov 3 2015, 6:37 PM
F2912025: Screen Shot 2015-11-03 at 19.33.02.png
Nov 3 2015, 6:37 PM
F2912021: Screen Shot 2015-11-03 at 19.32.47.png
Nov 3 2015, 6:37 PM
Subscribers
Aklapper
gerritbot
Jdlrobson
StudiesWorld
TheDJ

Description

The chevrons are initialised pointing downward, but that should be upward. After manual uncollapsing they do not change and recollapsing they are have the right direction again. This seems to be a recent regression introduced by I38c17eacc452942aea8942328c7b26cff0e50d99.

Screen Shot 2015-11-03 at 19.32.47.png (498×472 px, 60 KB)
Screen Shot 2015-11-03 at 19.32.53.png (437×477 px, 97 KB)
Screen Shot 2015-11-03 at 19.33.02.png (330×476 px, 51 KB)

Details

SubjectRepoBranchLines +/-
Fix collapsible header arrowsmediawiki/extensions/MobileFrontendmaster+5 -5
Customize query in gerrit

Event Timeline

TheDJ created this task.Nov 3 2015, 6:37 PM
TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added projects: Web-Team-Backlog, Regression, Mobile.
TheDJ subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptNov 3 2015, 6:37 PM
Jdlrobson edited projects, added MobileFrontend; removed Web-Team-Backlog.Nov 3 2015, 7:11 PM
Jdlrobson set Security to None.
Jdlrobson renamed this task from Collapse chevron indicators on mobile web initialized incorrectly to Regression: Collapse chevron indicators on mobile web initialized incorrectly.Nov 3 2015, 7:39 PM
Jdlrobson added a project: Reading Web Sprint 59 - Amsterdam and the hamsters.
Jdlrobson moved this task from Needs Analysis to To Do on the Reading Web Sprint 59 - Amsterdam and the hamsters board.
• jhobs claimed this task.Nov 3 2015, 9:52 PM
• jhobs moved this task from To Do to Doing on the Reading Web Sprint 59 - Amsterdam and the hamsters board.
gerritbot subscribed.Nov 3 2015, 9:54 PM

Change 250838 had a related patch set uploaded (by Jhobs):
Fix collapsible header arrows

https://gerrit.wikimedia.org/r/250838

gerritbot added a project: Patch-For-Review.Nov 3 2015, 9:54 PM
• jhobs moved this task from Doing to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 3 2015, 9:54 PM
Jdlrobson subscribed.Nov 3 2015, 11:10 PM

The commit before the regression the arrow was:

  • pointing down when collapsed
  • pointing up when expanded.

With your commit it's the opposite:

  • pointing up when collapsed
  • pointing down with expanded.
Jdlrobson updated the task description. (Show Details)Nov 3 2015, 11:13 PM
Jdlrobson added a comment.Nov 3 2015, 11:18 PM

I clarified the description. It seems they've always pointed downwards when collapsed.
See this early screenshot for example :)
https://www.mediawiki.org/wiki/File:MobileFrontendSectionPage.png

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 3 2015, 11:19 PM
• jhobs moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 3 2015, 11:25 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 4 2015, 1:05 AM
Jdlrobson moved this task from Backlog to team:other on the MobileFrontend board.Nov 4 2015, 5:21 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 4 2015, 6:05 PM
• jhobs triaged this task as Medium priority.Nov 4 2015, 6:10 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 4 2015, 9:10 PM
gerritbot added a comment.Nov 4 2015, 9:14 PM

Change 250838 merged by jenkins-bot:
Fix collapsible header arrows

https://gerrit.wikimedia.org/r/250838

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).Nov 4 2015, 10:00 PM
Jdlrobson closed this task as Resolved.Nov 4 2015, 11:06 PM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading Web Sprint 59 - Amsterdam and the hamsters board.Nov 5 2015, 11:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL