Page MenuHomePhabricator

[RfC] Usage of HTML IDs on entity pages
Closed, ResolvedPublic

Description

In https://gerrit.wikimedia.org/r/#/c/60596/, HTML IDs claims and sitelinks were added to entity views. The plan was to only have them on entity pages, but that was never implemented. Instead, with https://gerrit.wikimedia.org/r/#/c/154416/, they get added to all entity views in JS, too.

Questions:

  • Do we want to use IDs at all?
  • Do we only want them on entity pages?
  • Do we need new / different IDs?

Event Timeline

@Lydia_Pintscher pointed out that we have a lot more IDs:

  • wb-item-$ENTITYID on entity views
  • $PROPERTYID on statement groups
  • sitelinks-$SITELINKGROUPID on sitelink groups

Do we want to use IDs at all?

Yes I think so as people do want to link to individual parts of an item to make it easier to find that part.

Do we only want them on entity pages?

Do they hurt elsewhere?

Do we need new / different IDs?

Probably one for the identifier section at least, yes.

They hurt if you are on someone else's HTML page and start using unqualified ids, or if you have something twice on a page.

Decision: We continue using IDs as we do currently for the time being.