Page MenuHomePhabricator

Include "rcid" parameter in all eligible diff URLs
Closed, DeclinedPublic

Description

The mark as patrolled button now only shows up if you look at an edit from the
RC. So you cannot mark the edits if you look at all edits of a user from the
list of contribution.

The request is to add the mark as patrolled button if you look at a change from
another link than from recent changes. For instance if you look at the change
from the list of (anonymous) user contribution, or if you look at a certain edit
from the history page.


Version: unspecified
Severity: enhancement

Details

Reference
bz9798

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 9:40 PM
bzimport set Reference to bz9798.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Contribution lists and page histories pull data from a different source than the various change lists; patrolling information doesn't last forever, so once a change is no longer "recent", it can't be patrolled.

Note that the correct fix would be to make patrolling no longer dependent on passing around recentchanges table row IDs, since that's kind of weird and fragile. Then no "rcid" parameter will appear anywhere.