Page MenuHomePhabricator
Create Task
Maniphest T117984

Fix easy problems reported by RuboCop in MultimediaViewer
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/TrailingBlankLines RuboCop offensemediawiki/extensions/MultimediaViewermaster+1 -12
Fixed Style/Semicolon RuboCop offensemediawiki/extensions/MultimediaViewermaster+1 -8
Fixed Style/RegexpLiteral RuboCop offensemediawiki/extensions/MultimediaViewermaster+9 -18
Fixed Style/LeadingCommentSpace RuboCop offensemediawiki/extensions/MultimediaViewermaster+1 -7
Fixed Lint/UnusedBlockArgument RuboCop offensemediawiki/extensions/MultimediaViewermaster+2 -10
Updated RuboCop to the latest versionmediawiki/extensions/MultimediaViewermaster+63 -39
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Nov 6 2015, 4:13 PM
zeljkofilipin claimed this task.
zeljkofilipin raised the priority of this task from to Medium.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added projects: Browser-Tests-Infrastructure, MediaViewer.
zeljkofilipin subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2015, 4:13 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 6 2015, 4:16 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Nov 6 2015, 4:19 PM
zeljkofilipin edited projects, added Browser-Tests, Ruby; removed Browser-Tests-Infrastructure.Nov 6 2015, 5:58 PM
zeljkofilipin set Security to None.
zeljkofilipin claimed this task.Nov 25 2015, 3:25 PM
zeljkofilipin added a project: Browser-Tests-Infrastructure.
zeljkofilipin moved this task from Inbox to Next on the Browser-Tests-Infrastructure board.
gerritbot subscribed.Dec 9 2015, 3:32 PM

Change 257894 had a related patch set uploaded (by Zfilipin):
Updated RuboCop to the latest version

https://gerrit.wikimedia.org/r/257894

gerritbot added a project: Patch-For-Review.Dec 9 2015, 3:32 PM
gerritbot added a comment.Dec 9 2015, 3:57 PM

Change 257903 had a related patch set uploaded (by Zfilipin):
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/257903

gerritbot added a comment.Dec 9 2015, 4:22 PM

Change 257909 had a related patch set uploaded (by Zfilipin):
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/257909

gerritbot added a comment.Dec 9 2015, 4:22 PM

Change 257910 had a related patch set uploaded (by Zfilipin):
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/257910

gerritbot added a comment.Dec 9 2015, 4:22 PM

Change 257911 had a related patch set uploaded (by Zfilipin):
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/257911

gerritbot added a comment.Dec 9 2015, 4:22 PM

Change 257912 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/257912

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257894 merged by jenkins-bot:
Updated RuboCop to the latest version

https://gerrit.wikimedia.org/r/257894

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257903 merged by jenkins-bot:
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/257903

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257909 merged by jenkins-bot:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/257909

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257910 merged by jenkins-bot:
Fixed Style/RegexpLiteral RuboCop offense

https://gerrit.wikimedia.org/r/257910

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257911 merged by jenkins-bot:
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/257911

gerritbot added a comment.Dec 9 2015, 5:33 PM

Change 257912 merged by jenkins-bot:
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/257912

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 9 2015, 6:00 PM
Jdlrobson closed this task as Resolved.Dec 9 2015, 6:50 PM
Jdlrobson subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits