Page MenuHomePhabricator
Create Task
Maniphest T120188

Do not set wpb-banner-options if the custom and wikidata banner are invalid.
Closed, ResolvedPublic
Actions

Description

If {{PAGEBANNER...}} fails to find a valid custom banner, 'wpb-banner-options' shouldn't be set. This property should only be set if either the custom banner is valid or the article has an associated wikidata banner.

Details

SubjectRepoBranchLines +/-
Do not set wpb-banner-options if the custom and wikidata banner are invalidmediawiki/extensions/WikidataPageBannermaster+25 -2
Customize query in gerrit

Event Timeline

Sumit created this task.Dec 3 2015, 9:12 AM
Sumit raised the priority of this task from to Needs Triage.
Sumit updated the task description. (Show Details)
Sumit added projects: Wikidata-Page-Banner, Google-Code-In-2015, good first task.
Sumit moved this task to In discussion on the Wikidata-Page-Banner board.
Sumit subscribed.
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 3 2015, 9:12 AM
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Dec 3 2015, 3:32 PM
Sumit updated the task description. (Show Details)Dec 3 2015, 6:13 PM
Sumit set Security to None.
Jdlrobson triaged this task as Medium priority.Dec 4 2015, 6:03 PM
Jdlrobson subscribed.
Aklapper added a comment.Dec 5 2015, 3:55 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/5031362054586368/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 5 2015, 3:55 PM
Neonowy claimed this task.Dec 15 2015, 12:50 AM
gerritbot subscribed.Dec 15 2015, 1:29 AM

Change 259203 had a related patch set uploaded (by Neonowy):
Do not set wpb-banner-options if the custom and wikidata banner are invalid

https://gerrit.wikimedia.org/r/259203

gerritbot added a project: Patch-For-Review.Dec 15 2015, 1:29 AM
gerritbot added a comment.Dec 15 2015, 7:42 PM

Change 259203 merged by jenkins-bot:
Do not set wpb-banner-options if the custom and wikidata banner are invalid

https://gerrit.wikimedia.org/r/259203

Jdlrobson closed this task as Resolved.Dec 15 2015, 7:46 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 15 2015, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL