Page MenuHomePhabricator
Create Task
Maniphest T121308

[Regression] Save button (for article edits) not working in mobile VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I just made a minor edit using iOS 9's Safari browser. I was using the "visual editor." Upon hitting Save, nothing happens. Yet, when I try to switch away from visual editing, or when I attempt to back out of the editor, I get an alert asking, "Do you really want to abandon your edit."

Nothing I do causes the edit to be saved.

Details

SubjectRepoBranchLines +/-
Add targets to duplicated resource loader definitions (EasyDeflate)mediawiki/extensions/ContentTranslationmaster+12 -0
Add targets to duplicated resource loader definitions (EasyDeflate)mediawiki/extensions/ContentTranslationwmf/1.27.0-wmf.8+12 -0
Add targets to duplicated resource loader definitions (EasyDeflate)mediawiki/extensions/ContentTranslationwmf/1.27.0-wmf.9+12 -0
Customize query in gerrit

Event Timeline

SyncopatorSyncopator created this task.Dec 12 2015, 12:25 PM
SyncopatorSyncopator raised the priority of this task from to Needs Triage.
SyncopatorSyncopator updated the task description. (Show Details)
SyncopatorSyncopator subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 12 2015, 12:25 PM
Krenair added projects: VisualEditor, VisualEditor-MediaWiki-Mobile.Dec 12 2015, 3:46 PM
Krenair subscribed.
Jdforrester-WMF triaged this task as High priority.Dec 15 2015, 8:18 PM
Jdforrester-WMF added a project: Browser-Support-Apple-Safari.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Esanders renamed this task from Save button (for article edits) not working in iOS 9's Safari browser to [Regression] Save button (for article edits) not working in mobile VE.Dec 15 2015, 10:20 PM
Esanders removed a project: Browser-Support-Apple-Safari.
Esanders subscribed.

Strange problem with RL. A whole bunch on modules aren't available on mobile:

mw.loader.moduleRegistry['easy-deflate.core']
undefined

Esanders added a comment.Dec 15 2015, 10:23 PM

But I can't reproduce locally.

Esanders raised the priority of this task from High to Unbreak Now!.Dec 15 2015, 10:36 PM
gerritbot subscribed.Dec 15 2015, 10:39 PM

Change 259417 had a related patch set uploaded (by Esanders):
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259417

gerritbot added a project: Patch-For-Review.Dec 15 2015, 10:39 PM

Change 259418 had a related patch set uploaded (by Krinkle):
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259418

gerritbot added a comment.Dec 15 2015, 10:41 PM

Change 259419 had a related patch set uploaded (by Krinkle):
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259419

gerritbot added a comment.Dec 15 2015, 11:06 PM

Change 259419 merged by jenkins-bot:
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259419

gerritbot added a comment.Dec 15 2015, 11:16 PM

Change 259418 merged by Krinkle:
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259418

Esanders closed this task as Resolved.Dec 15 2015, 11:32 PM
Esanders claimed this task.
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 16 2015, 12:00 AM
gerritbot added a comment.Dec 16 2015, 12:15 AM

Change 259417 merged by jenkins-bot:
Add targets to duplicated resource loader definitions (EasyDeflate)

https://gerrit.wikimedia.org/r/259417

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).Dec 16 2015, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL