Maniphest T121428

[5.0.0(542)] As a user, I should see the error view and error banner when tapping a link while offline
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• BGerstle-WMF
	Dec 14 2015, 7:13 PM

Tags

Referenced Files

	F3088937: IMG_0468.PNG
	Dec 14 2015, 11:08 PM

	F3088935: IMG_0467.PNG
	Dec 14 2015, 11:08 PM

Subscribers

• BGerstle-WMF

Description

Steps to repro

Save a page (also try w/ a recent page that isn't saved)
Enable airplane mode
Go back to page while offline
Tap a link

Expected results

Error banner slides down from top of screen saying I'm offline, and the article view is in its "error state."

Actual results

Blank screen, no message

Event Timeline

• BGerstle-WMF created this task.Dec 14 2015, 7:13 PM

• BGerstle-WMF raised the priority of this task from to Needs Triage.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF added a project: Wikipedia-iOS-App-Development.

• BGerstle-WMF moved this task to Tasks from Product Backlog on the Wikipedia-iOS-App-Development board.

• BGerstle-WMF subscribed.

Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptDec 14 2015, 7:13 PM

• BGerstle-WMF triaged this task as High priority.Dec 14 2015, 7:13 PM

• BGerstle-WMF set Security to None.

• BGerstle-WMF added a project: iOS-app-v5-beta.

• Fjalapeno claimed this task.Dec 14 2015, 7:18 PM

• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.

verified fixed in latest on master

• Fjalapeno moved this task from Doing to Needs QA on the Wikipedia-iOS-App-Development board.Dec 14 2015, 7:21 PM

Etonkovidova moved this task from Needs QA to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Dec 14 2015, 10:54 PM

Checked with 5.0.0.551 on iPad mini iOS 8.2

IMG_0467.PNG (2×1 px, 73 KB)

vs 4.1.7(171)

IMG_0468.PNG (640×480 px, 240 KB)

NOTE: - 'Save' icon is clickable, so it's possible to save articles that are not displayed. After saving articles in offline mode, they can be read in online mode without any issues. 'Save' works perfectly. Might be a feature? - In 4.1.7(171) a user does not even get a blank page with a warning banner. Clicking on a link, the banner is displayed -and no other actions are happening.

I don't think allowing save while offline was intentional, but if it works, then lets leave as is.